From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Triplett Subject: Re: [PATCH 19/55] scsi: Mark function as static in isci/phy.c Date: Mon, 31 Mar 2014 02:36:28 -0700 Message-ID: <20140331093628.GB1202@leaf> References: <5fd6fa49a592043459f75ed83a72f8c1ed9ddc13.1396114897.git.rashika.kheria@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Dorau, Lukasz" Cc: Rashika Kheria , "linux-kernel@vger.kernel.org" , intel-linux-scu , "Patelczyk, Maciej" , "Jiang, Dave" , "James E.J. Bottomley" , "linux-scsi@vger.kernel.org" , "Paszkiewicz, Artur" List-Id: linux-scsi@vger.kernel.org On Mon, Mar 31, 2014 at 08:54:49AM +0000, Dorau, Lukasz wrote: > On Saturday, March 29, 2014 7:04 PM Rashika Kheria wrote: > >=20 > > Mark function as static in isci/phy.c because it is not used outsid= e > > this file. > >=20 > > This eliminates the following warning in isci/phy.c: > > drivers/scsi/isci/phy.c:672:6: warning: no previous prototype for > > =E2=80=98scu_link_layer_set_txcomsas_timeout=E2=80=99 [-Wmissing-pr= ototypes] > >=20 > > Signed-off-by: Rashika Kheria > > Reviewed-by: Josh Triplett >=20 > Acked-by: Lukasz Dorau Since you're a maintainer of the driver in question, can you accept the three patches you acked, or would you suggest that they go through another tree? - Josh Triplett