From: Christoph Hellwig <hch@infradead.org>
To: linux-scsi@vger.kernel.org, James Smart <james.smart@emulex.com>
Subject: SCSI_MLQUEUE_EH_RETRY?
Date: Mon, 7 Apr 2014 07:39:50 -0700 [thread overview]
Message-ID: <20140407143950.GA11925@infradead.org> (raw)
While the comments and code structure in scsi_io_completion suggest that
calling __scsi_queue_insert with SCSI_MLQUEUE_EH_RETRY has a different
effect from using SCSI_MLQUEUE_DEVICE_BUSY they are treated exactly the
same.
It seems like when SCSI_MLQUEUE_EH_RETRY was introduced it didn't set
device_blocked, but since commit 573e5913536a1393362265cfea9e708aa10fdf16
"[SCSI] scsi_lib: pause between error retries" they are one and the
same.
Is there any point in keeping SCSI_MLQUEUE_EH_RETRY?
reply other threads:[~2014-04-07 14:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140407143950.GA11925@infradead.org \
--to=hch@infradead.org \
--cc=james.smart@emulex.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).