linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* SCSI_MLQUEUE_EH_RETRY?
@ 2014-04-07 14:39 Christoph Hellwig
  0 siblings, 0 replies; only message in thread
From: Christoph Hellwig @ 2014-04-07 14:39 UTC (permalink / raw)
  To: linux-scsi, James Smart

While the comments and code structure in scsi_io_completion suggest that
calling __scsi_queue_insert with SCSI_MLQUEUE_EH_RETRY has a different
effect from using SCSI_MLQUEUE_DEVICE_BUSY they are treated exactly the
same.

It seems like when SCSI_MLQUEUE_EH_RETRY was introduced it didn't set
device_blocked, but since commit 573e5913536a1393362265cfea9e708aa10fdf16
"[SCSI] scsi_lib: pause between error retries" they are one and the
same.

Is there any point in keeping SCSI_MLQUEUE_EH_RETRY?

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-04-07 14:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-07 14:39 SCSI_MLQUEUE_EH_RETRY? Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).