From: Dan Carpenter <dan.carpenter@oracle.com>
To: naresh@chelsio.com
Cc: linux-scsi@vger.kernel.org
Subject: re: [SCSI] csiostor: Chelsio FCoE offload driver
Date: Wed, 16 Apr 2014 18:33:24 +0300 [thread overview]
Message-ID: <20140416153324.GA16325@mwanda> (raw)
Hello Naresh Kumar Inna,
The patch a3667aaed569: "[SCSI] csiostor: Chelsio FCoE offload
driver" from Nov 15, 2012, leads to the following static checker
warning:
drivers/scsi/csiostor/csio_mb.c:1534 csio_mb_isr_handler()
warn: was 'sizeof(*mbp)' intended?
drivers/scsi/csiostor/csio_mb.c
1451 int
1452 csio_mb_isr_handler(struct csio_hw *hw)
1453 {
1454 struct csio_mbm *mbm = &hw->mbm;
^^^
This struct is fairly large.
1455 struct csio_mb *mbp = mbm->mcurrent;
1456 __be64 *cmd;
1457 uint32_t ctl, cim_cause, pl_cause;
1458 int i;
1459 uint32_t ctl_reg = PF_REG(hw->pfn, CIM_PF_MAILBOX_CTRL);
[ snip ]
1530 /*
1531 * Enqueue event to EventQ. Events processing happens
1532 * in Event worker thread context
1533 */
1534 if (csio_enqueue_evt(hw, CSIO_EVT_MBX, mbp, sizeof(mbp)))
^^^^^^^^^^
This is equivalent to sizeof(long) when sizeof(*mbp) was probably
intended.
1535 CSIO_INC_STATS(hw, n_evt_drop);
1536
regards,
dan carpenter
next reply other threads:[~2014-04-16 15:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 15:33 Dan Carpenter [this message]
2014-04-16 15:37 ` [SCSI] csiostor: Chelsio FCoE offload driver Dan Carpenter
2015-02-26 9:49 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2013-02-06 13:09 Dan Carpenter
2013-02-08 7:34 ` Naresh Kumar Inna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416153324.GA16325@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=naresh@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).