* [patch] [SCSI] qla2xxx: fix incorrect debug printk
@ 2014-05-03 20:21 Dan Carpenter
2014-05-05 9:45 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2014-05-03 20:21 UTC (permalink / raw)
To: qla2xxx-upstream; +Cc: James E.J. Bottomley, linux-scsi, kernel-janitors
There are missing curly braces here so it prints that the recovery
failed even when it succeeded.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
static checker stuff. not tested.
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index afc8481..00754a2 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -4913,12 +4913,13 @@ qla2x00_do_dpc(void *data)
if (qlafx00_reset_initialize(base_vha)) {
/* Failed. Abort isp later. */
+ &base_vha->dpc_flags)) {
set_bit(ISP_UNRECOVERABLE,
&base_vha->dpc_flags);
ql_dbg(ql_dbg_dpc, base_vha,
0x4021,
"Reset Recovery Failed\n");
+ }
}
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch] [SCSI] qla2xxx: fix incorrect debug printk
2014-05-03 20:21 [patch] [SCSI] qla2xxx: fix incorrect debug printk Dan Carpenter
@ 2014-05-05 9:45 ` Dan Carpenter
2014-05-05 9:47 ` [patch v2] " Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2014-05-05 9:45 UTC (permalink / raw)
To: qla2xxx-upstream; +Cc: James E.J. Bottomley, linux-scsi, kernel-janitors
On Sat, May 03, 2014 at 11:21:35PM +0300, Dan Carpenter wrote:
> There are missing curly braces here so it prints that the recovery
> failed even when it succeeded.
>
That's strange. This patch got corrupted somehow. I will resend.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* [patch v2] [SCSI] qla2xxx: fix incorrect debug printk
2014-05-05 9:45 ` Dan Carpenter
@ 2014-05-05 9:47 ` Dan Carpenter
2014-05-05 18:52 ` Chad Dupuis
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2014-05-05 9:47 UTC (permalink / raw)
To: qla2xxx-upstream; +Cc: James E.J. Bottomley, linux-scsi, kernel-janitors
There are missing curly braces here so it prints that the recovery
failed even when it succeeded.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: version 1 patch was corrupted in sending somehow.
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index afc8481..00754a2 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -4913,12 +4913,13 @@ qla2x00_do_dpc(void *data)
if (qlafx00_reset_initialize(base_vha)) {
/* Failed. Abort isp later. */
if (!test_bit(UNLOADING,
- &base_vha->dpc_flags))
+ &base_vha->dpc_flags)) {
set_bit(ISP_UNRECOVERABLE,
&base_vha->dpc_flags);
ql_dbg(ql_dbg_dpc, base_vha,
0x4021,
"Reset Recovery Failed\n");
+ }
}
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch v2] [SCSI] qla2xxx: fix incorrect debug printk
2014-05-05 9:47 ` [patch v2] " Dan Carpenter
@ 2014-05-05 18:52 ` Chad Dupuis
0 siblings, 0 replies; 4+ messages in thread
From: Chad Dupuis @ 2014-05-05 18:52 UTC (permalink / raw)
To: Dan Carpenter
Cc: Dept-Eng QLA2xxx Upstream, James E.J. Bottomley, linux-scsi,
kernel-janitors@vger.kernel.org
On Mon, 5 May 2014, Dan Carpenter wrote:
> There are missing curly braces here so it prints that the recovery
> failed even when it succeeded.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: version 1 patch was corrupted in sending somehow.
>
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index afc8481..00754a2 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -4913,12 +4913,13 @@ qla2x00_do_dpc(void *data)
> if (qlafx00_reset_initialize(base_vha)) {
> /* Failed. Abort isp later. */
> if (!test_bit(UNLOADING,
> - &base_vha->dpc_flags))
> + &base_vha->dpc_flags)) {
> set_bit(ISP_UNRECOVERABLE,
> &base_vha->dpc_flags);
> ql_dbg(ql_dbg_dpc, base_vha,
> 0x4021,
> "Reset Recovery Failed\n");
> + }
> }
> }
>
>
Looks good. Thanks.
Reviewed-by: Giridhar Malavali <giridhar.malavali@qlogic.com>
Acked-by: Chad Dupuis <chad.dupuis@qlogic.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-05 18:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-03 20:21 [patch] [SCSI] qla2xxx: fix incorrect debug printk Dan Carpenter
2014-05-05 9:45 ` Dan Carpenter
2014-05-05 9:47 ` [patch v2] " Dan Carpenter
2014-05-05 18:52 ` Chad Dupuis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox