linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Stephen M. Cameron" <scameron@beardog.cce.hp.com>
To: james.bottomley@hansenpartnership.com
Cc: justin.lindley@hp.com, martin.petersen@oracle.com,
	linux-scsi@vger.kernel.org, stephenmcameron@gmail.com,
	joseph.t.handzik@hp.com, thenzl@redhat.com,
	michael.miller@canonical.com, elliott@hp.com, scott.teel@hp.com
Subject: [PATCH 16/19] hpsa: fix event filtering to prevent excessive rescans with old firmware
Date: Thu, 08 May 2014 14:28:45 -0500	[thread overview]
Message-ID: <20140508192845.13481.98508.stgit@beardog.cce.hp.com> (raw)
In-Reply-To: <20140508192239.13481.81880.stgit@beardog.cce.hp.com>

From: Stephen M. Cameron <scameron@beardog.cce.hp.com>

CTLR_STATE_CHANGE_EVENT and CTLR_STATE_CHANGE_EVENT_REDUNDANT_CNTRL
do not require rescans to be initiated.  Current firmware filters out
these events already, but some out of date firmware doesn't, so the
driver needs to filter them out too.  Without this change and with out
of date firmware you may see the driver spending a lot of time
scanning devices unnecessarily on some Smart Arrays.

Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
---
 drivers/scsi/hpsa.h |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h
index 1855469..18f5093 100644
--- a/drivers/scsi/hpsa.h
+++ b/drivers/scsi/hpsa.h
@@ -228,11 +228,9 @@ struct ctlr_info {
 #define CTLR_STATE_CHANGE_EVENT_AIO_CONFIG_CHANGE	(1 << 31)
 
 #define RESCAN_REQUIRED_EVENT_BITS \
-		(CTLR_STATE_CHANGE_EVENT | \
-		CTLR_ENCLOSURE_HOT_PLUG_EVENT | \
+		(CTLR_ENCLOSURE_HOT_PLUG_EVENT | \
 		CTLR_STATE_CHANGE_EVENT_PHYSICAL_DRV | \
 		CTLR_STATE_CHANGE_EVENT_LOGICAL_DRV | \
-		CTLR_STATE_CHANGE_EVENT_REDUNDANT_CNTRL | \
 		CTLR_STATE_CHANGE_EVENT_AIO_ENABLED_DISABLED | \
 		CTLR_STATE_CHANGE_EVENT_AIO_CONFIG_CHANGE)
 	spinlock_t offline_device_lock;


  parent reply	other threads:[~2014-05-08 19:29 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-08 19:27 [PATCH 00/19] hpsa driver updates May 8, 2014 Stephen M. Cameron
2014-05-08 19:27 ` [PATCH 01/19] hpsa: add new Smart Array PCI IDs (May 2014) Stephen M. Cameron
2014-05-08 19:27 ` [PATCH 02/19] Checking for a NULL return from a kzalloc call in hpsa_get_pdisk_of_ioaccel2 Stephen M. Cameron
2014-05-08 19:27 ` [PATCH 03/19] hpsa: remove unused fields from struct ctlr_info Stephen M. Cameron
2014-05-08 19:27 ` [PATCH 04/19] hpsa: allow passthru ioctls to work with bidirectional commands Stephen M. Cameron
2014-05-08 19:27 ` [PATCH 05/19] hpsa: change doorbell reset delay to ten seconds Stephen M. Cameron
2014-05-08 19:27 ` [PATCH 06/19] hpsa: use gcc aligned attribute instead of manually padding structs Stephen M. Cameron
2014-05-08 19:27 ` [PATCH 07/19] hpsa: remove dev_dbg() calls from hot paths Stephen M. Cameron
2014-05-08 19:28 ` [PATCH 08/19] hpsa: choose number of reply queues more intelligently Stephen M. Cameron
2014-05-08 19:28 ` [PATCH 09/19] hpsa: allocate reply queues individually Stephen M. Cameron
2014-05-08 19:28 ` [PATCH 10/19] hpsa: set irq affinity hints to route MSI-X vectors across CPUs Stephen M. Cameron
2014-05-08 21:11   ` Govindarajulu Varadarajan
2014-05-08 22:04     ` Elliott, Robert (Server Storage)
2014-05-08 19:28 ` [PATCH 11/19] hpsa: use per-cpu variable for lockup_detected Stephen M. Cameron
2014-05-08 19:28 ` [PATCH 12/19] hpsa: avoid unnecessary readl on every command submission Stephen M. Cameron
2014-05-08 19:28 ` [PATCH 13/19] hpsa: Rearrange start_io to avoid one unlock/lock sequence in main io path Stephen M. Cameron
2014-05-08 19:28 ` [PATCH 14/19] hpsa: define extended_report_lun_entry data structure Stephen M. Cameron
2014-05-08 19:28 ` [PATCH 15/19] hpsa: kill annoying messages about SSD Smart Path retries Stephen M. Cameron
2014-05-08 19:28 ` Stephen M. Cameron [this message]
2014-05-08 19:28 ` [PATCH 17/19] hpsa: remove bad unlikely annotation from device list updating code Stephen M. Cameron
2014-05-08 19:28 ` [PATCH 18/19] hpsa: report check condition even if no sense data present for ioaccel2 mode Stephen M. Cameron
2014-05-08 19:29 ` [PATCH 19/19] hpsa: remove messages about volume status VPD inquiry page not supported Stephen M. Cameron
2014-05-19 17:18 ` [PATCH 00/19] hpsa driver updates May 8, 2014 Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140508192845.13481.98508.stgit@beardog.cce.hp.com \
    --to=scameron@beardog.cce.hp.com \
    --cc=elliott@hp.com \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=joseph.t.handzik@hp.com \
    --cc=justin.lindley@hp.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=michael.miller@canonical.com \
    --cc=scott.teel@hp.com \
    --cc=stephenmcameron@gmail.com \
    --cc=thenzl@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).