From: Christoph Hellwig <hch@lst.de>
To: Maurizio Lombardi <mlombard@redhat.com>
Cc: Hannes Reinecke <hare@suse.de>,
linux-scsi@vger.kernel.org, JBottomley@Parallels.com,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] scsi: replace numeric messages with string error messages when blk_execute_rq fails. Also add printing of sense info.
Date: Thu, 15 May 2014 08:41:10 +0200 [thread overview]
Message-ID: <20140515064110.GA7410@lst.de> (raw)
In-Reply-To: <20140513142401.GC2015@dhcp-27-189.brq.redhat.com>
On Tue, May 13, 2014 at 04:24:02PM +0200, Maurizio Lombardi wrote:
> On Tue, May 13, 2014 at 04:14:47PM +0200, Hannes Reinecke wrote:
> > If you were to go ahead with the patch please strip the first
> > scsi_execute() altogether and use the VPD information already
> > provided by the scsi device.
>
> The patch I'm asking to merge just adds some printks, nothing else,
> it does not make use of scsi_execute():
>
> http://www.spinics.net/lists/linux-scsi/msg73984.html
We now have a readily available copy of EVPD page 0x83 hanging off
the scsi device, so the alua device handler should use it.
Hannes, how about you handle that if you're doing major surgery in that
area anwyay?
next prev parent reply other threads:[~2014-05-15 6:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 11:44 [PATCH] scsi: replace numeric messages with string error messages when blk_execute_rq fails. Also add printing of sense info Maurizio Lombardi
2014-04-25 13:12 ` Christoph Hellwig
2014-04-25 15:40 ` Maurizio Lombardi
2014-04-29 9:30 ` Maurizio Lombardi
2014-04-29 18:00 ` Christoph Hellwig
2014-05-13 13:10 ` Maurizio Lombardi
2014-05-13 14:07 ` Christoph Hellwig
2014-05-13 14:14 ` Hannes Reinecke
2014-05-13 14:24 ` Maurizio Lombardi
2014-05-15 6:41 ` Christoph Hellwig [this message]
2014-06-04 7:51 ` Maurizio Lombardi
2014-06-04 7:53 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140515064110.GA7410@lst.de \
--to=hch@lst.de \
--cc=JBottomley@Parallels.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=mlombard@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).