linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
	linux-scsi@vger.kernel.org,
	James Bottomley <jbottomley@parallels.com>
Subject: Re: [PATCH 2/5] scsi_scan: Restrict sequential scan to 256 LUNs
Date: Thu, 22 May 2014 02:08:47 -0700	[thread overview]
Message-ID: <20140522090847.GC14854@infradead.org> (raw)
In-Reply-To: <1400583791-123120-3-git-send-email-hare@suse.de>

On Tue, May 20, 2014 at 01:03:08PM +0200, Hannes Reinecke wrote:
> Sequential scan for more than 256 LUNs is very fragile as
> LUNs might not be numbered sequentially after that point.
> 
> SAM revisions later than SCSI-3 impose a structure on
> LUNs larger than 256, making LUN numbers between 256
> and 16384 illegal.
> SCSI-3, however allows for plain 64-bit numbers with
> no internal structure.
> 
> So restrict sequential LUN scan to 256 LUNs and add a
> new blacklist flag 'BLIST_SCSI3LUN' to scan up to
> max_lun devices.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

Do you know any common devices reporting SCSI-2?  I've only really seen 
SCSI-2 and never SBC levels in practical use.

  reply	other threads:[~2014-05-22  9:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-20 11:03 [PATCHv2 0/5] Support 64-bit LUNs Hannes Reinecke
2014-05-20 11:03 ` [PATCH 1/5] scsi: Remove CONFIG_SCSI_MULTI_LUN Hannes Reinecke
2014-05-22  9:07   ` Christoph Hellwig
2014-05-20 11:03 ` [PATCH 2/5] scsi_scan: Restrict sequential scan to 256 LUNs Hannes Reinecke
2014-05-22  9:08   ` Christoph Hellwig [this message]
2014-05-20 11:03 ` [PATCH 3/5] qla2xxx: Restrict max_lun to 16-bit for older HBAs Hannes Reinecke
2014-05-20 13:32   ` Chad Dupuis
2014-05-22  9:09   ` Christoph Hellwig
2014-05-20 11:03 ` [PATCH 4/5] scsi: use 64-bit LUNs Hannes Reinecke
2014-05-22  9:10   ` Christoph Hellwig
2014-05-20 11:03 ` [PATCH 5/5] scsi: use 64-bit value for 'max_luns' Hannes Reinecke
2014-05-22  9:10   ` Christoph Hellwig
2014-05-28 10:56 ` [PATCHv2 0/5] Support 64-bit LUNs Christoph Hellwig
2014-05-29  8:39   ` James Bottomley
2014-05-28 20:30 ` Ewan Milne
  -- strict thread matches above, loose matches on Subject: below --
2013-12-10 11:05 [PATCH 0/5][RFC] " Hannes Reinecke
2013-12-10 11:05 ` [PATCH 2/5] scsi_scan: Restrict sequential scan to 256 LUNs Hannes Reinecke
2014-03-27 14:49   ` Christoph Hellwig
2014-03-28  8:22     ` Hannes Reinecke
2014-03-28 12:47       ` Christoph Hellwig
2014-03-28 13:19         ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140522090847.GC14854@infradead.org \
    --to=hch@infradead.org \
    --cc=hare@suse.de \
    --cc=jbottomley@parallels.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).