From: Christoph Hellwig <hch@infradead.org>
To: Tyler Stachecki <tstache1@binghamton.edu>
Cc: Nagalakshmi.Nandigama@lsi.com, Sreekanth.Reddy@lsi.com,
JBottomley@parallels.com, DL-MPTFusionLinux@lsi.com,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] [SCSI] mpt2sas: Don't disable device twice at suspend.
Date: Wed, 28 May 2014 03:45:08 -0700 [thread overview]
Message-ID: <20140528104508.GA911@infradead.org> (raw)
In-Reply-To: <1398458464-11826-1-git-send-email-tstache1@binghamton.edu>
On Fri, Apr 25, 2014 at 04:41:04PM -0400, Tyler Stachecki wrote:
> On suspend, _scsih_suspend calls mpt2sas_base_free_resources, which
> in turn calls pci_disable_device if the device is enabled prior to
> suspending. However, _scsih_suspend also calls pci_disable_device
> itself.
>
> Thus, in the event that the device is enabled prior to suspending,
> pci_disable_device will be called twice. This patch removes the
> duplicate call to pci_disable_device in _scsi_suspend as it is both
> unnecessary and results in a kernel oops.
>
> Signed-off-by: Tyler Stachecki <tstache1@binghamton.edu>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2014-05-28 10:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 20:41 [PATCH] [SCSI] mpt2sas: Don't disable device twice at suspend Tyler Stachecki
2014-05-28 10:45 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140528104508.GA911@infradead.org \
--to=hch@infradead.org \
--cc=DL-MPTFusionLinux@lsi.com \
--cc=JBottomley@parallels.com \
--cc=Nagalakshmi.Nandigama@lsi.com \
--cc=Sreekanth.Reddy@lsi.com \
--cc=linux-scsi@vger.kernel.org \
--cc=tstache1@binghamton.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).