From: Christoph Hellwig <hch@infradead.org>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>,
Jiri Kosina <jkosina@suse.cz>,
Randy Dunlap <rdunlap@infradead.org>,
Masanari Iida <standby24x7@gmail.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: mvsas: mv_sas.c: Fix for possible null pointer dereference
Date: Wed, 28 May 2014 04:27:21 -0700 [thread overview]
Message-ID: <20140528112721.GC11953@infradead.org> (raw)
In-Reply-To: <1400429547-11342-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On Sun, May 18, 2014 at 06:12:26PM +0200, Rickard Strandqvist wrote:
> There is otherwise a risk of a possible null pointer dereference.
>
> Was largely found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Looks good, although I'd love to know how a NULL dev could even happen
here.
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2014-05-28 11:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-18 16:12 [PATCH] scsi: mvsas: mv_sas.c: Fix for possible null pointer dereference Rickard Strandqvist
2014-05-28 11:27 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140528112721.GC11953@infradead.org \
--to=hch@infradead.org \
--cc=JBottomley@parallels.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=standby24x7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).