linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Stephen M. Cameron" <scameron@beardog.cce.hp.com>
To: james.bottomley@parallels.com
Cc: webb.scales@hp.com, martin.petersen@oracle.com,
	linux-scsi@vger.kernel.org, justin.lindley@hp.com,
	stephenmcameron@gmail.com, joseph.t.handzik@hp.com,
	thenzl@redhat.com, michael.miller@canonical.com,
	scott.teel@hp.com, hch@lst.de, dan.carpenter@oracle.com
Subject: [PATCH 2 05/24] hpsa: change doorbell reset delay to ten seconds
Date: Thu, 29 May 2014 10:52:47 -0500	[thread overview]
Message-ID: <20140529155246.8180.70657.stgit@beardog.cce.hp.com> (raw)
In-Reply-To: <20140529154739.8180.50710.stgit@beardog.cce.hp.com>

From: Justin Lindley <justin.lindley@hp.com>

After 3.22 firmware, PMC firmware guys tell us the
previous 5 second delay after a reset now needs to
be 10 secs to avoid a PCIe error due to the driver
looking at the controller too soon after the reset.

Signed-off-by: Justin Lindley <justin.lindley@hp.com>
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Reviewed-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
---
 drivers/scsi/hpsa.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 1df9a8a..2220b32 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -5831,12 +5831,12 @@ static int hpsa_controller_hard_reset(struct pci_dev *pdev,
 		dev_info(&pdev->dev, "using doorbell to reset controller\n");
 		writel(use_doorbell, vaddr + SA5_DOORBELL);
 
-		/* PMC hardware guys tell us we need a 5 second delay after
+		/* PMC hardware guys tell us we need a 10 second delay after
 		 * doorbell reset and before any attempt to talk to the board
 		 * at all to ensure that this actually works and doesn't fall
 		 * over in some weird corner cases.
 		 */
-		msleep(5000);
+		msleep(10000);
 	} else { /* Try to do it the PCI power state way */
 
 		/* Quoting from the Open CISS Specification: "The Power


  parent reply	other threads:[~2014-05-29 15:54 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-29 15:52 [PATCH 2 00/24] Resend of May 2014 patches for hpsa driver Stephen M. Cameron
2014-05-29 15:52 ` [PATCH 2 01/24] hpsa: add new Smart Array PCI IDs (May 2014) Stephen M. Cameron
2014-05-29 15:52 ` [PATCH 2 02/24] hpsa: fix missing check of kzalloc return value Stephen M. Cameron
2014-05-29 15:52 ` [PATCH 2 03/24] hpsa: remove unused fields from struct ctlr_info Stephen M. Cameron
2014-05-29 15:52 ` [PATCH 2 04/24] hpsa: allow passthru ioctls to work with bidirectional commands Stephen M. Cameron
2014-05-29 15:52 ` Stephen M. Cameron [this message]
2014-05-29 15:52 ` [PATCH 2 06/24] hpsa: use gcc aligned attribute instead of manually padding structs Stephen M. Cameron
2014-05-29 15:52 ` [PATCH 2 07/24] hpsa: remove dev_dbg() calls from hot paths Stephen M. Cameron
2014-05-29 15:53 ` [PATCH 2 08/24] hpsa: choose number of reply queues more intelligently Stephen M. Cameron
2014-06-02  9:27   ` Christoph Hellwig
2014-06-02 14:52     ` scameron
2014-06-02 15:00       ` scameron
2014-05-29 15:53 ` [PATCH 2 09/24] hpsa: allocate reply queues individually Stephen M. Cameron
2014-05-29 15:53 ` [PATCH 2 10/24] hpsa: set irq affinity hints to route MSI-X vectors across CPUs Stephen M. Cameron
2014-05-29 15:53 ` [PATCH 2 11/24] hpsa: use per-cpu variable for lockup_detected Stephen M. Cameron
2014-05-29 15:53 ` [PATCH 2 12/24] hpsa: avoid unnecessary readl on every command submission Stephen M. Cameron
2014-05-29 15:53 ` [PATCH 2 13/24] hpsa: Rearrange start_io to avoid one unlock/lock sequence in main io path Stephen M. Cameron
2014-05-29 15:53 ` [PATCH 2 14/24] hpsa: define extended_report_lun_entry data structure Stephen M. Cameron
2014-05-29 15:53 ` [PATCH 2 15/24] hpsa: kill annoying messages about SSD Smart Path retries Stephen M. Cameron
2014-05-29 15:53 ` [PATCH 2 16/24] hpsa: fix event filtering to prevent excessive rescans with old firmware Stephen M. Cameron
2014-05-29 15:53 ` [PATCH 2 17/24] hpsa: remove bad unlikely annotation from device list updating code Stephen M. Cameron
2014-05-29 15:53 ` [PATCH 2 18/24] hpsa: report check condition even if no sense data present for ioaccel2 mode Stephen M. Cameron
2014-05-29 15:54 ` [PATCH 2 19/24] hpsa: fix memory leak in hpsa_hba_mode_enabled Stephen M. Cameron
2014-05-29 15:54 ` [PATCH 2 20/24] hpsa: do not ignore failure of sense controller parameters command Stephen M. Cameron
2014-05-29 15:54 ` [PATCH 2 21/24] hpsa: remove messages about volume status VPD inquiry page not supported Stephen M. Cameron
2014-05-29 15:54 ` [PATCH 2 22/24] hpsa: fix bad comparison of signed with unsigned in hpsa_update_scsi_devices Stephen M. Cameron
2014-05-29 15:54 ` [PATCH 2 23/24] hpsa: return -ENOMEM not -1 on kzalloc failure in hpsa_get_device_id Stephen M. Cameron
2014-05-29 15:54 ` [PATCH 2 24/24] hpsa: fix handling of hpsa_volume_offline return value Stephen M. Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140529155246.8180.70657.stgit@beardog.cce.hp.com \
    --to=scameron@beardog.cce.hp.com \
    --cc=dan.carpenter@oracle.com \
    --cc=hch@lst.de \
    --cc=james.bottomley@parallels.com \
    --cc=joseph.t.handzik@hp.com \
    --cc=justin.lindley@hp.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=michael.miller@canonical.com \
    --cc=scott.teel@hp.com \
    --cc=stephenmcameron@gmail.com \
    --cc=thenzl@redhat.com \
    --cc=webb.scales@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).