From: Christoph Hellwig <hch@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: James Bottomley <jbottomley@parallels.com>,
Christoph Hellwig <hch@infradead.org>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 3/3] scsi: Implement 'ZBC' device type
Date: Mon, 2 Jun 2014 02:19:31 -0700 [thread overview]
Message-ID: <20140602091931.GC32301@infradead.org> (raw)
In-Reply-To: <1401692478-23557-4-git-send-email-hare@suse.de>
> diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
> index e02b3aa..0788213 100644
> --- a/drivers/scsi/scsi_scan.c
> +++ b/drivers/scsi/scsi_scan.c
> @@ -819,6 +819,7 @@ static int scsi_add_lun(struct scsi_device *sdev, unsigned char *inq_result,
> case TYPE_COMM:
> case TYPE_RAID:
> case TYPE_OSD:
> + case TYPE_ZBC:
> sdev->writeable = 1;
> break;
> case TYPE_ROM:
sdev->writeable is only used in the sd and sr drivers, so we should
just remove it from the scsi_device structure and track it internally
to get rid of this layering violation.
prev parent reply other threads:[~2014-06-02 9:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 7:01 [PATCH 0/3] Initial SMR drive support Hannes Reinecke
2014-06-02 7:01 ` [PATCH 1/3] libata: consolidate ata_dev_classify() Hannes Reinecke
2014-06-02 9:16 ` Christoph Hellwig
2014-06-02 7:01 ` [PATCH 2/3] libata: Implement ATA_DEV_ZAC Hannes Reinecke
2014-06-02 9:17 ` Christoph Hellwig
2014-06-14 6:37 ` Hannes Reinecke
2014-06-02 7:01 ` [PATCH 3/3] scsi: Implement 'ZBC' device type Hannes Reinecke
2014-06-02 8:39 ` Christoph Hellwig
2014-06-02 8:46 ` Hannes Reinecke
2014-06-02 9:20 ` Christoph Hellwig
2014-06-02 9:19 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602091931.GC32301@infradead.org \
--to=hch@infradead.org \
--cc=hare@suse.de \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).