From: Christoph Hellwig <hch@infradead.org>
To: Joe Lawrence <joe.lawrence@stratus.com>
Cc: linux-scsi@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>,
Sreekanth Reddy <Sreekanth.Reddy@lsi.com>
Subject: Re: [PATCH 3/4] mpt3sas: fix possible memory leak in mpt3sas_send_trigger_data_event
Date: Mon, 2 Jun 2014 09:31:50 -0700 [thread overview]
Message-ID: <20140602163150.GB26828@infradead.org> (raw)
In-Reply-To: <1401719846-18446-1-git-send-email-joe.lawrence@stratus.com>
On Mon, Jun 02, 2014 at 10:37:26AM -0400, Joe Lawrence wrote:
> If mpt3sas_send_trigger_data_event exits early without inserting a
> fw_event, be sure to undo any prior allocations.
Looks good, but why don't we just allocate the two in a single
allocation?
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2014-06-02 16:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 14:34 [PATCH 0/4] mpt2/mpt3 static checker fixups Joe Lawrence
2014-06-02 14:34 ` [PATCH 1/4] mpt2sas: correct scsi_{target,device} hostdata allocation Joe Lawrence
2014-06-02 16:30 ` Christoph Hellwig
2014-06-02 14:37 ` [PATCH 3/4] mpt3sas: fix possible memory leak in mpt3sas_send_trigger_data_event Joe Lawrence
2014-06-02 16:31 ` Christoph Hellwig [this message]
2014-06-02 20:41 ` Christoph Hellwig <hch@infradead.org> wrote: Joe Lawrence
2014-06-02 14:38 ` [PATCH 2/4] mpt3sas: correct scsi_{target,device} hostdata allocation Joe Lawrence
2014-06-02 16:32 ` Christoph Hellwig
2014-06-02 14:38 ` [PATCH 4/4] mpt2sas: annotate ioc->reply_post_host_index as __iomem Joe Lawrence
2014-06-02 16:32 ` Christoph Hellwig
2014-06-02 16:33 ` [PATCH 0/4] mpt2/mpt3 static checker fixups Christoph Hellwig
2014-06-02 20:44 ` Joe Lawrence
2014-06-25 9:43 ` Sreekanth Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602163150.GB26828@infradead.org \
--to=hch@infradead.org \
--cc=Sreekanth.Reddy@lsi.com \
--cc=dan.carpenter@oracle.com \
--cc=joe.lawrence@stratus.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).