From: "hch@infradead.org" <hch@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "hch@infradead.org" <hch@infradead.org>,
James Bottomley <jbottomley@parallels.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"MinhDuc.Tran@Emulex.Com" <MinhDuc.Tran@emulex.com>,
"jayamohank@gmail.com" <jayamohank@gmail.com>,
"michaelc@cs.wisc.edu" <michaelc@cs.wisc.edu>,
"Sony.John-N@Emulex.Com" <Sony.John-N@emulex.com>,
"Jayamohan.Kallickal@Emulex.Com" <Jayamohan.Kallickal@emulex.com>
Subject: Re: [PATCH 7/8] be2iscsi: Fix processing cqe for cxn whose endpoint is freed
Date: Mon, 2 Jun 2014 13:08:13 -0700 [thread overview]
Message-ID: <20140602200813.GA8118@infradead.org> (raw)
In-Reply-To: <CA+55aFy+VTFqBi5aQLdB7=04wWmf+gvZzQ1vdrSEuscN7k3xGw@mail.gmail.com>
On Mon, Jun 02, 2014 at 01:05:38PM -0700, Linus Torvalds wrote:
> I would indeed prefer to avoid rebases, _unless_ the tree is a real
> mess without it.
>
> Now, what constitues "real mess" can vary. It can be just really ugly
> history, and part of that can be "it doesn't build or work at all
> partway through". If it causes major build or boot failures the code
> is *not* worth merging as-is, because that ends up being really
> painful for bisection etc. But for it to matter for bisection, it has
> to be a _major_ failure that actually matters to real people. So I'm
> not talking about odd "make randomconfig" failures, but painful build
> failures that actually hit reasonable configurations, and boot
> failures that hit relevant hardware configurations.
It's reverting a patch that just doesn't fix a problem fully, so the
prime reviewer and the patch author decided to withdraw it. It won't
cause any kind of problem during bisection.
next prev parent reply other threads:[~2014-06-02 20:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 1:41 [PATCH 1/8] be2iscsi: Fix retrieving MCCQ_WRB in non-embedded Mbox path Jay Kallickal
2014-05-06 1:41 ` [PATCH 2/8] be2iscsi: Fix exposing Host in sysfs after adapter initialization is complete Jay Kallickal
2014-05-06 1:41 ` [PATCH 3/8] be2iscsi: Fix interrupt Coalescing mechanism Jay Kallickal
2014-05-06 1:41 ` [PATCH 4/8] be2iscsi: Fix TCP parameters while connection offloading Jay Kallickal
2014-05-06 1:41 ` [PATCH 5/8] be2iscsi: Fix memory corruption in MBX path Jay Kallickal
2014-05-06 1:41 ` [PATCH 6/8] be2iscsi: Fix destroy MCC-CQ before MCC-EQ is destroyed Jay Kallickal
2014-05-06 1:41 ` [PATCH 7/8] be2iscsi: Fix processing cqe for cxn whose endpoint is freed Jay Kallickal
2014-05-07 22:18 ` Mike Christie
2014-05-28 15:51 ` Christoph Hellwig
2014-06-02 5:52 ` Sony John-N
2014-06-02 6:46 ` Christoph Hellwig
2014-06-02 19:22 ` James Bottomley
2014-06-02 19:33 ` hch
2014-06-02 20:02 ` James Bottomley
2014-06-02 20:05 ` Linus Torvalds
2014-06-02 20:08 ` hch [this message]
2014-06-02 20:24 ` Linus Torvalds
2014-06-02 20:32 ` hch
2014-05-06 1:41 ` [PATCH 8/8] be2iscsi: Bump the driver version Jay Kallickal
2014-05-06 1:41 ` [PATCH 0/8] be2iscsi: update to 10.2.273.0 Jay Kallickal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602200813.GA8118@infradead.org \
--to=hch@infradead.org \
--cc=Jayamohan.Kallickal@emulex.com \
--cc=MinhDuc.Tran@emulex.com \
--cc=Sony.John-N@emulex.com \
--cc=jayamohank@gmail.com \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).