From: "Bryn M. Reeves" <bmr@redhat.com>
To: Laurence Oberman <oberman.l@gmail.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: debug_flag added to st tape driver
Date: Tue, 10 Jun 2014 22:20:30 +0100 [thread overview]
Message-ID: <20140610212029.GA30598@localhost.localdomain> (raw)
In-Reply-To: <CAAzz28jMu0VeQHZNHWD0jM3YREZrPERnPvTxONStyaV7foFc_Q@mail.gmail.com>
On Tue, Jun 10, 2014 at 04:57:06PM -0400, Laurence Oberman wrote:
> I am tired of building modules to enable SCSI tape driver debug so I
> am hoping this patch is acceptable.
> Tested using kernel 3.14.6
>
> Usage example:
> modprobe st debug_flag=1
Missing Signed-off-by :-)
> +module_param_named(debug_flag, debug_flag, int, 0);
It's probably not worth making this a sysfs knob as most distros
still compile st as a module although why not just set debugging
directly from the module parameter?
> +MODULE_PARM_DESC(debug_flag, "Enable DEBUG, same as setting DEBUG 1
> in source");
> +
The description is a bit misleading as a bunch of stuff gets
compiled out when DEBUG is unset at compile time.
Maybe "same as setting debugging=1" instead?
prev parent reply other threads:[~2014-06-10 21:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 20:57 debug_flag added to st tape driver Laurence Oberman
2014-06-10 21:20 ` Bryn M. Reeves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140610212029.GA30598@localhost.localdomain \
--to=bmr@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=oberman.l@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox