From: Christoph Hellwig <hch@infradead.org>
To: Vaughan Cao <vaughan.cao@oracle.com>
Cc: JBottomley@parallels.com, hch@infradead.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] notify block layer when using temporary change to cache_type
Date: Wed, 11 Jun 2014 05:07:13 -0700 [thread overview]
Message-ID: <20140611120713.GB16616@infradead.org> (raw)
In-Reply-To: <1401788250-8457-1-git-send-email-vaughan.cao@oracle.com>
On Tue, Jun 03, 2014 at 05:37:30PM +0800, Vaughan Cao wrote:
> This is a fix for commit:
> 39c60a0948cc06139e2fbfe084f83cb7e7deae3b sd: fix array cache flushing bug causing performance problems
> We must notify the block layer via q->flush_flags after temporary change the cache_type to write through.
> If not, SYNCHRONIZE CACHE command will still be generated.
> This patch factors out a helper that can be called from sd_revalidate_disk and cache_type_store.
>
> Signed-off-by: Vaughan Cao <vaughan.cao@oracle.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2014-06-11 12:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 9:37 [PATCH v2] notify block layer when using temporary change to cache_type Vaughan Cao
2014-06-11 12:07 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140611120713.GB16616@infradead.org \
--to=hch@infradead.org \
--cc=JBottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=vaughan.cao@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).