[PATCH 0/4] ARM randconfig fixes for SCSI

[PATCH 0/4] ARM randconfig fixes for SCSI

[Arnd Bergmann]

Hi James,

These are some fixes for ancient randconfig build bugs I
ran into on ARM. Clearly none of these are urgent, but it
would be nice to have them merged for 3.17 if they look
good to you.

Arnd Bergmann (4):
  [SCSI] Don't build AdvanSys on ARM
  [SCSI] pas16: don't call free_dma()
  [SCSI] qlogicfas: don't call free_dma()
  [SCSI] NCR53c406a: don't call free_dma() by default

 drivers/scsi/Kconfig      | 2 +-
 drivers/scsi/NCR53c406a.c | 2 +-
 drivers/scsi/pas16.c      | 2 --
 drivers/scsi/qlogicfas.c  | 2 --
 4 files changed, 2 insertions(+), 6 deletions(-)

-- 
1.8.3.2

Cc: Matthew Wilcox <matthew@wil.cx>
Cc: Finn Thain <fthain@telegraphics.com.au>
Cc: Michael Schmitz <schmitzmic@gmail.com>

[PATCH 1/4] [SCSI] Don't build AdvanSys on ARM

[Arnd Bergmann]

The advansys SCSI driver uses the dma_cache_sync function, which is
not available on the ARM architecture, and cannot be implemented
correctly, so we always get this build error:

drivers/scsi/advansys.c: In function 'advansys_get_sense_buffer_dma':
drivers/scsi/advansys.c:7882:2: error: implicit declaration of function 'dma_cache_sync' [-Werror=implicit-function-declaration]
  dma_cache_sync(board->dev, scp->sense_buffer,
  ^

It seems nobody has missed this driver so far, so let's just
disable it for ARM to help randconfig builds.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Matthew Wilcox <matthew@wil.cx>
---
 drivers/scsi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index baca589..8368e00 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -528,7 +528,7 @@ config SCSI_DPT_I2O
 
 config SCSI_ADVANSYS
 	tristate "AdvanSys SCSI support"
-	depends on SCSI && VIRT_TO_BUS
+	depends on SCSI && VIRT_TO_BUS && !ARM
 	depends on ISA || EISA || PCI
 	help
 	  This is a driver for all SCSI host adapters manufactured by
-- 
1.8.3.2

Re: [PATCH 1/4] [SCSI] Don't build AdvanSys on ARM

[Christoph Hellwig]

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

[PATCH 2/4] [SCSI] pas16: don't call free_dma()

[Arnd Bergmann]

The pas16 scsi driver does not use DMA, and the call to free_dma()
in its exit function seems to have been copied incorrectly from
another driver but never caused trouble.

One case where it gets in the way is randconfig builds on ARM,
which depending on the configuration does not provide a free_dma()
function, causing this build error:

drivers/scsi/pas16.c: In function 'pas16_release':
drivers/scsi/pas16.c:611:3: error: implicit declaration of function 'free_dma' [-Werror=implicit-function-declaration]
   free_dma(shost->dma_channel);

Removing the incorrect function calls should be the obvious
fix for this, with no downsides.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Finn Thain <fthain@telegraphics.com.au>
Cc: Michael Schmitz <schmitzmic@gmail.com>
---
 drivers/scsi/pas16.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/pas16.c b/drivers/scsi/pas16.c
index 0d78a4d..80bacb5 100644
--- a/drivers/scsi/pas16.c
+++ b/drivers/scsi/pas16.c
@@ -607,8 +607,6 @@ static int pas16_release(struct Scsi_Host *shost)
 	if (shost->irq)
 		free_irq(shost->irq, shost);
 	NCR5380_exit(shost);
-	if (shost->dma_channel != 0xff)
-		free_dma(shost->dma_channel);
 	if (shost->io_port && shost->n_io_port)
 		release_region(shost->io_port, shost->n_io_port);
 	scsi_unregister(shost);
-- 
1.8.3.2

Re: [PATCH 2/4] [SCSI] pas16: don't call free_dma()

[Christoph Hellwig]

On Thu, Jun 05, 2014 at 11:29:47PM +0200, Arnd Bergmann wrote:
> The pas16 scsi driver does not use DMA, and the call to free_dma()
> in its exit function seems to have been copied incorrectly from
> another driver but never caused trouble.
> 
> One case where it gets in the way is randconfig builds on ARM,
> which depending on the configuration does not provide a free_dma()
> function, causing this build error:

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

[PATCH 3/4] [SCSI] qlogicfas: don't call free_dma()

[Arnd Bergmann]

The qlogicfas scsi driver does not use DMA, and the call to free_dma()
in its exit function seems to have been copied incorrectly from
another driver but never caused trouble.

One case where it gets in the way is randconfig builds on ARM,
which depending on the configuration does not provide a free_dma()
function, causing this build error:

drivers/scsi/qlogicfas.c: In function 'qlogicfas_release':
drivers/scsi/qlogicfas.c:175:3: error: implicit declaration of function 'free_dma' [-Werror=implicit-function-declaration]
   free_dma(shost->dma_channel);
   ^

Removing the incorrect function calls should be the obvious
fix for this, with no downsides.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/scsi/qlogicfas.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/qlogicfas.c b/drivers/scsi/qlogicfas.c
index 13d628b..a22bb1b 100644
--- a/drivers/scsi/qlogicfas.c
+++ b/drivers/scsi/qlogicfas.c
@@ -171,8 +171,6 @@ static int qlogicfas_release(struct Scsi_Host *shost)
 		qlogicfas408_disable_ints(priv);	
 		free_irq(shost->irq, shost);
 	}
-	if (shost->dma_channel != 0xff)
-		free_dma(shost->dma_channel);
 	if (shost->io_port && shost->n_io_port)
 		release_region(shost->io_port, shost->n_io_port);
 	scsi_host_put(shost);
-- 
1.8.3.2

Re: [PATCH 3/4] [SCSI] qlogicfas: don't call free_dma()

[Christoph Hellwig]

On Thu, Jun 05, 2014 at 11:29:48PM +0200, Arnd Bergmann wrote:
> The qlogicfas scsi driver does not use DMA, and the call to free_dma()
> in its exit function seems to have been copied incorrectly from
> another driver but never caused trouble.
> 
> One case where it gets in the way is randconfig builds on ARM,
> which depending on the configuration does not provide a free_dma()
> function, causing this build error:

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

[PATCH 4/4] [SCSI] NCR53c406a: don't call free_dma() by default

[Arnd Bergmann]

The NCR53c406a scsi driver normally does not use DMA, unless
the USE_PIO macro is disabled by modifying the source code.

The call to free_dma() for some reason uses #ifdef USE_DMA,
which does not do the right thing, since USE_DMA is defined
as a boolean that is either 0 or 1, but always present.

One case where it gets in the way is randconfig builds on ARM,
which depending on the configuration does not provide a free_dma()
function, causing this build error:

drivers/scsi/NCR53c406a.c: In function 'NCR53c406a_release':
drivers/scsi/NCR53c406a.c:600:3: error: implicit declaration of function 'free_dma' [-Werror=implicit-function-declaration]
   free_dma(shost->dma_channel);
   ^

This changes the code to use #if USE_DMA, to match the
rest of the file, which seems to be what the author intended.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/scsi/NCR53c406a.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/NCR53c406a.c b/drivers/scsi/NCR53c406a.c
index c91888a..2c78785 100644
--- a/drivers/scsi/NCR53c406a.c
+++ b/drivers/scsi/NCR53c406a.c
@@ -595,7 +595,7 @@ static int NCR53c406a_release(struct Scsi_Host *shost)
 {
 	if (shost->irq)
 		free_irq(shost->irq, NULL);
-#ifdef USE_DMA
+#if USE_DMA
 	if (shost->dma_channel != 0xff)
 		free_dma(shost->dma_channel);
 #endif
-- 
1.8.3.2

Re: [PATCH 4/4] [SCSI] NCR53c406a: don't call free_dma() by default

[Christoph Hellwig]

On Thu, Jun 05, 2014 at 11:29:49PM +0200, Arnd Bergmann wrote:
> The NCR53c406a scsi driver normally does not use DMA, unless
> the USE_PIO macro is disabled by modifying the source code.
> 
> The call to free_dma() for some reason uses #ifdef USE_DMA,
> which does not do the right thing, since USE_DMA is defined
> as a boolean that is either 0 or 1, but always present.
> 
> One case where it gets in the way is randconfig builds on ARM,
> which depending on the configuration does not provide a free_dma()
> function, causing this build error:

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

Re: [PATCH 0/4] ARM randconfig fixes for SCSI

[Christoph Hellwig]

Can I get another set of reviews for these?

On Thu, Jun 05, 2014 at 11:29:45PM +0200, Arnd Bergmann wrote:
> Hi James,
> 
> These are some fixes for ancient randconfig build bugs I
> ran into on ARM. Clearly none of these are urgent, but it
> would be nice to have them merged for 3.17 if they look
> good to you.
> 
> Arnd Bergmann (4):
>   [SCSI] Don't build AdvanSys on ARM
>   [SCSI] pas16: don't call free_dma()
>   [SCSI] qlogicfas: don't call free_dma()
>   [SCSI] NCR53c406a: don't call free_dma() by default
> 
>  drivers/scsi/Kconfig      | 2 +-
>  drivers/scsi/NCR53c406a.c | 2 +-
>  drivers/scsi/pas16.c      | 2 --
>  drivers/scsi/qlogicfas.c  | 2 --
>  4 files changed, 2 insertions(+), 6 deletions(-)
> 
> -- 
> 1.8.3.2
> 
> Cc: Matthew Wilcox <matthew@wil.cx>
> Cc: Finn Thain <fthain@telegraphics.com.au>
> Cc: Michael Schmitz <schmitzmic@gmail.com>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
---end quoted text---

Re: [PATCH 0/4] ARM randconfig fixes for SCSI

[Finn Thain]

On Wed, 25 Jun 2014, Christoph Hellwig wrote:

> Can I get another set of reviews for these?

Reviewed-by: Finn Thain <fthain@telegraphics.com.au>

(All four patches.)

> >   [SCSI] pas16: don't call free_dma()
> >   [SCSI] qlogicfas: don't call free_dma()

BTW, I found that the suprious free_dma() calls appeared in 2.5.73 when a 
generic release implementation was apparently added to drivers that lacked 
any release method.

--