From: Christoph Hellwig <hch@infradead.org>
To: Venkatesh Srinivas <venkateshs@google.com>
Cc: hare@suse.de, hch@infradead.org,
Paolo Bonzini <pbonzini@redhat.com>,
JBottomley@parallels.com, linux-scsi@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: virtio-scsi issues duplicate tags when async_abort is enabled
Date: Fri, 13 Jun 2014 11:52:21 -0700 [thread overview]
Message-ID: <20140613185221.GA11872@infradead.org> (raw)
In-Reply-To: <CAHdzE-8k6A6kVB7DnOc6_XKg6DANLRFmP9+f4oXE1vPoLhOK=g@mail.gmail.com>
On Fri, Jun 13, 2014 at 10:58:22AM -0700, Venkatesh Srinivas wrote:
> CC-ing stable as 3.14 and 3.15 are affected; a conservative fix is to
> enable no_async_abort until the problem is better-understood.
No patch attached. Nevermind this is not a consdervative fix, but a
band aid. The proper fix is to figure out what's actually going on
here.
>From your trace above it very much looks like a double completion of
some sort.
I've looked at the virtio-scsi code a bit, and one odd thing it does
that comes in handy here is that it doesn't really use a traditional
tag, but rather the address of the scsi command.
Knowning that your above traces mean that we are resending a command
to the HBA/storage that has a pending abort going on.
next prev parent reply other threads:[~2014-06-13 18:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 17:58 virtio-scsi issues duplicate tags when async_abort is enabled Venkatesh Srinivas
2014-06-13 18:37 ` Hannes Reinecke
2014-06-13 18:43 ` Venkatesh Srinivas
2014-06-13 18:52 ` Christoph Hellwig [this message]
2014-06-13 19:09 ` James Bottomley
2014-06-13 19:15 ` Venkatesh Srinivas
2014-06-13 19:18 ` James Bottomley
2014-06-13 19:31 ` Greg KH
2014-06-13 19:29 ` James Bottomley
2014-06-14 2:50 ` Venkatesh Srinivas
2014-06-14 15:10 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140613185221.GA11872@infradead.org \
--to=hch@infradead.org \
--cc=JBottomley@parallels.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=stable@vger.kernel.org \
--cc=venkateshs@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox