* [PATCH 1/1] Add defines for new FC port speeds.
@ 2014-06-13 16:40 Dick Kennedy
2014-06-13 16:45 ` Christoph Hellwig
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Dick Kennedy @ 2014-06-13 16:40 UTC (permalink / raw)
To: linux-scsi@vger.kernel.org
These speeds are to support the next generation of FCoE port speeds.
Signed-off-by: rkennedy@emulex.com
---
drivers/scsi/scsi_transport_fc.c | 4 ++++
include/scsi/scsi_transport_fc.h | 4 ++++
2 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
index f80908f..454cc28 100644
--- a/drivers/scsi/scsi_transport_fc.c
+++ b/drivers/scsi/scsi_transport_fc.c
@@ -262,6 +262,10 @@ static const struct {
{ FC_PORTSPEED_8GBIT, "8 Gbit" },
{ FC_PORTSPEED_16GBIT, "16 Gbit" },
{ FC_PORTSPEED_32GBIT, "32 Gbit" },
+ { FC_PORTSPEED_20GBIT, "20 Gbit" },
+ { FC_PORTSPEED_40GBIT, "40 Gbit" },
+ { FC_PORTSPEED_50GBIT, "50 Gbit" },
+ { FC_PORTSPEED_100GBIT, "100 Gbit" },
{ FC_PORTSPEED_NOT_NEGOTIATED, "Not Negotiated" },
};
fc_bitfield_name_search(port_speed, fc_port_speed_names)
diff --git a/include/scsi/scsi_transport_fc.h b/include/scsi/scsi_transport_fc.h
index 8c79980..007a0bc 100644
--- a/include/scsi/scsi_transport_fc.h
+++ b/include/scsi/scsi_transport_fc.h
@@ -131,6 +131,10 @@ enum fc_vport_state {
#define FC_PORTSPEED_8GBIT 0x10
#define FC_PORTSPEED_16GBIT 0x20
#define FC_PORTSPEED_32GBIT 0x40
+#define FC_PORTSPEED_20GBIT 0x80
+#define FC_PORTSPEED_40GBIT 0x100
+#define FC_PORTSPEED_50GBIT 0x200
+#define FC_PORTSPEED_100GBIT 0x400
#define FC_PORTSPEED_NOT_NEGOTIATED (1 << 15) /* Speed not established */
/*
--
1.6.6
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] Add defines for new FC port speeds.
2014-06-13 16:40 [PATCH 1/1] Add defines for new FC port speeds Dick Kennedy
@ 2014-06-13 16:45 ` Christoph Hellwig
2014-06-25 10:57 ` Christoph Hellwig
2014-06-25 12:55 ` Ewan Milne
2 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2014-06-13 16:45 UTC (permalink / raw)
To: Dick Kennedy; +Cc: linux-scsi@vger.kernel.org
On Fri, Jun 13, 2014 at 04:40:36PM +0000, Dick Kennedy wrote:
> These speeds are to support the next generation of FCoE port speeds.
> Signed-off-by: rkennedy@emulex.com
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
(next time please add your fully name to the signoff line)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] Add defines for new FC port speeds.
2014-06-13 16:40 [PATCH 1/1] Add defines for new FC port speeds Dick Kennedy
2014-06-13 16:45 ` Christoph Hellwig
@ 2014-06-25 10:57 ` Christoph Hellwig
2014-07-09 10:47 ` Hannes Reinecke
2014-06-25 12:55 ` Ewan Milne
2 siblings, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2014-06-25 10:57 UTC (permalink / raw)
To: Dick Kennedy; +Cc: linux-scsi@vger.kernel.org
Can I get another review for this one?
On Fri, Jun 13, 2014 at 04:40:36PM +0000, Dick Kennedy wrote:
> These speeds are to support the next generation of FCoE port speeds.
> Signed-off-by: rkennedy@emulex.com
> ---
> drivers/scsi/scsi_transport_fc.c | 4 ++++
> include/scsi/scsi_transport_fc.h | 4 ++++
> 2 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
> index f80908f..454cc28 100644
> --- a/drivers/scsi/scsi_transport_fc.c
> +++ b/drivers/scsi/scsi_transport_fc.c
> @@ -262,6 +262,10 @@ static const struct {
> { FC_PORTSPEED_8GBIT, "8 Gbit" },
> { FC_PORTSPEED_16GBIT, "16 Gbit" },
> { FC_PORTSPEED_32GBIT, "32 Gbit" },
> + { FC_PORTSPEED_20GBIT, "20 Gbit" },
> + { FC_PORTSPEED_40GBIT, "40 Gbit" },
> + { FC_PORTSPEED_50GBIT, "50 Gbit" },
> + { FC_PORTSPEED_100GBIT, "100 Gbit" },
> { FC_PORTSPEED_NOT_NEGOTIATED, "Not Negotiated" },
> };
> fc_bitfield_name_search(port_speed, fc_port_speed_names)
> diff --git a/include/scsi/scsi_transport_fc.h b/include/scsi/scsi_transport_fc.h
> index 8c79980..007a0bc 100644
> --- a/include/scsi/scsi_transport_fc.h
> +++ b/include/scsi/scsi_transport_fc.h
> @@ -131,6 +131,10 @@ enum fc_vport_state {
> #define FC_PORTSPEED_8GBIT 0x10
> #define FC_PORTSPEED_16GBIT 0x20
> #define FC_PORTSPEED_32GBIT 0x40
> +#define FC_PORTSPEED_20GBIT 0x80
> +#define FC_PORTSPEED_40GBIT 0x100
> +#define FC_PORTSPEED_50GBIT 0x200
> +#define FC_PORTSPEED_100GBIT 0x400
> #define FC_PORTSPEED_NOT_NEGOTIATED (1 << 15) /* Speed not established */
>
> /*
> --
> 1.6.6
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
---end quoted text---
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] Add defines for new FC port speeds.
2014-06-25 10:57 ` Christoph Hellwig
@ 2014-07-09 10:47 ` Hannes Reinecke
0 siblings, 0 replies; 5+ messages in thread
From: Hannes Reinecke @ 2014-07-09 10:47 UTC (permalink / raw)
To: Christoph Hellwig, Dick Kennedy; +Cc: linux-scsi@vger.kernel.org
On 06/25/2014 12:57 PM, Christoph Hellwig wrote:
> Can I get another review for this one?
>
> On Fri, Jun 13, 2014 at 04:40:36PM +0000, Dick Kennedy wrote:
>> These speeds are to support the next generation of FCoE port speeds.
>> Signed-off-by: rkennedy@emulex.com
>> ---
>> drivers/scsi/scsi_transport_fc.c | 4 ++++
>> include/scsi/scsi_transport_fc.h | 4 ++++
>> 2 files changed, 8 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
>> index f80908f..454cc28 100644
>> --- a/drivers/scsi/scsi_transport_fc.c
>> +++ b/drivers/scsi/scsi_transport_fc.c
>> @@ -262,6 +262,10 @@ static const struct {
>> { FC_PORTSPEED_8GBIT, "8 Gbit" },
>> { FC_PORTSPEED_16GBIT, "16 Gbit" },
>> { FC_PORTSPEED_32GBIT, "32 Gbit" },
>> + { FC_PORTSPEED_20GBIT, "20 Gbit" },
>> + { FC_PORTSPEED_40GBIT, "40 Gbit" },
>> + { FC_PORTSPEED_50GBIT, "50 Gbit" },
>> + { FC_PORTSPEED_100GBIT, "100 Gbit" },
>> { FC_PORTSPEED_NOT_NEGOTIATED, "Not Negotiated" },
>> };
>> fc_bitfield_name_search(port_speed, fc_port_speed_names)
>> diff --git a/include/scsi/scsi_transport_fc.h b/include/scsi/scsi_transport_fc.h
>> index 8c79980..007a0bc 100644
>> --- a/include/scsi/scsi_transport_fc.h
>> +++ b/include/scsi/scsi_transport_fc.h
>> @@ -131,6 +131,10 @@ enum fc_vport_state {
>> #define FC_PORTSPEED_8GBIT 0x10
>> #define FC_PORTSPEED_16GBIT 0x20
>> #define FC_PORTSPEED_32GBIT 0x40
>> +#define FC_PORTSPEED_20GBIT 0x80
>> +#define FC_PORTSPEED_40GBIT 0x100
>> +#define FC_PORTSPEED_50GBIT 0x200
>> +#define FC_PORTSPEED_100GBIT 0x400
>> #define FC_PORTSPEED_NOT_NEGOTIATED (1 << 15) /* Speed not established */
>>
>> /*
>> --
>> 1.6.6
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] Add defines for new FC port speeds.
2014-06-13 16:40 [PATCH 1/1] Add defines for new FC port speeds Dick Kennedy
2014-06-13 16:45 ` Christoph Hellwig
2014-06-25 10:57 ` Christoph Hellwig
@ 2014-06-25 12:55 ` Ewan Milne
2 siblings, 0 replies; 5+ messages in thread
From: Ewan Milne @ 2014-06-25 12:55 UTC (permalink / raw)
To: Dick Kennedy, Christoph Hellwig; +Cc: linux-scsi@vger.kernel.org
On Fri, 2014-06-13 at 16:40 +0000, Dick Kennedy wrote:
> These speeds are to support the next generation of FCoE port speeds.
> Signed-off-by: rkennedy@emulex.com
> ---
> drivers/scsi/scsi_transport_fc.c | 4 ++++
> include/scsi/scsi_transport_fc.h | 4 ++++
> 2 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
> index f80908f..454cc28 100644
> --- a/drivers/scsi/scsi_transport_fc.c
> +++ b/drivers/scsi/scsi_transport_fc.c
> @@ -262,6 +262,10 @@ static const struct {
> { FC_PORTSPEED_8GBIT, "8 Gbit" },
> { FC_PORTSPEED_16GBIT, "16 Gbit" },
> { FC_PORTSPEED_32GBIT, "32 Gbit" },
> + { FC_PORTSPEED_20GBIT, "20 Gbit" },
> + { FC_PORTSPEED_40GBIT, "40 Gbit" },
> + { FC_PORTSPEED_50GBIT, "50 Gbit" },
> + { FC_PORTSPEED_100GBIT, "100 Gbit" },
> { FC_PORTSPEED_NOT_NEGOTIATED, "Not Negotiated" },
> };
> fc_bitfield_name_search(port_speed, fc_port_speed_names)
> diff --git a/include/scsi/scsi_transport_fc.h b/include/scsi/scsi_transport_fc.h
> index 8c79980..007a0bc 100644
> --- a/include/scsi/scsi_transport_fc.h
> +++ b/include/scsi/scsi_transport_fc.h
> @@ -131,6 +131,10 @@ enum fc_vport_state {
> #define FC_PORTSPEED_8GBIT 0x10
> #define FC_PORTSPEED_16GBIT 0x20
> #define FC_PORTSPEED_32GBIT 0x40
> +#define FC_PORTSPEED_20GBIT 0x80
> +#define FC_PORTSPEED_40GBIT 0x100
> +#define FC_PORTSPEED_50GBIT 0x200
> +#define FC_PORTSPEED_100GBIT 0x400
> #define FC_PORTSPEED_NOT_NEGOTIATED (1 << 15) /* Speed not established */
>
> /*
> --
> 1.6.6
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-07-09 10:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-13 16:40 [PATCH 1/1] Add defines for new FC port speeds Dick Kennedy
2014-06-13 16:45 ` Christoph Hellwig
2014-06-25 10:57 ` Christoph Hellwig
2014-07-09 10:47 ` Hannes Reinecke
2014-06-25 12:55 ` Ewan Milne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).