From: Christoph Hellwig <hch@infradead.org>
To: Maurizio Lombardi <mlombard@redhat.com>
Cc: jayamohan.kallickal@emulex.com, linux-scsi@vger.kernel.org,
michaelc@cs.wisc.edu, JBottomley@parallels.com,
Tomas Henzl <thenzl@redhat.com>
Subject: Re: [PATCH] beiscsi: the custom_length field has been set to a wrong value.
Date: Mon, 7 Jul 2014 15:57:57 +0200 [thread overview]
Message-ID: <20140707135757.GA30059@infradead.org> (raw)
In-Reply-To: <1403774186-4751-1-git-send-email-mlombard@redhat.com>
On Thu, Jun 26, 2014 at 11:16:26AM +0200, Maurizio Lombardi wrote:
> In the beiscsi_conn_get_stats() function, custom_length should be set
> to 1 to take into account the "eh_abort_cnt" field at custom[0].
>
> Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Any chance to get a review on this one?
> ---
> drivers/scsi/be2iscsi/be_iscsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/be2iscsi/be_iscsi.c b/drivers/scsi/be2iscsi/be_iscsi.c
> index fd284ff..8616281 100644
> --- a/drivers/scsi/be2iscsi/be_iscsi.c
> +++ b/drivers/scsi/be2iscsi/be_iscsi.c
> @@ -914,7 +914,7 @@ void beiscsi_conn_get_stats(struct iscsi_cls_conn *cls_conn,
> stats->r2t_pdus = conn->r2t_pdus_cnt;
> stats->digest_err = 0;
> stats->timeout_err = 0;
> - stats->custom_length = 0;
> + stats->custom_length = 1;
> strcpy(stats->custom[0].desc, "eh_abort_cnt");
> stats->custom[0].value = conn->eh_abort_cnt;
> }
> --
> Maurizio Lombardi
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
---end quoted text---
next prev parent reply other threads:[~2014-07-07 13:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 9:16 [PATCH] beiscsi: the custom_length field has been set to a wrong value Maurizio Lombardi
2014-07-07 13:57 ` Christoph Hellwig [this message]
2014-07-07 15:35 ` Tomas Henzl
2014-07-07 15:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140707135757.GA30059@infradead.org \
--to=hch@infradead.org \
--cc=JBottomley@parallels.com \
--cc=jayamohan.kallickal@emulex.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=mlombard@redhat.com \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox