scsi: SCSI_FC_TGT_ATTRS

scsi: SCSI_FC_TGT_ATTRS

[Paul Bolle]

0) Commit 73685a458f2e ("tgt: removal") landed in next-20140714. It
states that "the CONFIG_SCSI_TGT, CONFIG_SCSI_SRP_TGT_ATTRS and
CONFIG_SCSI_FC_TGT_ATTRS kbuild variable[s] [...] are no longer needed".
It removed the Kconfig entry for SCSI_SRP_TGT_ATTRS, but it left the
entries for SCSI_TGT and SCSI_FC_TGT_ATTRS untouched.

1) Both SCSI_TGT and SCSI_FC_TGT_ATTRS appear to be unused after that
commit. Is a patch to remove their Kconfig entries queued somewhere?


Paul Bolle

Re: scsi: SCSI_FC_TGT_ATTRS

[Christoph Hellwig]

On Mon, Jul 14, 2014 at 10:29:04AM +0200, Paul Bolle wrote:
> 0) Commit 73685a458f2e ("tgt: removal") landed in next-20140714. It
> states that "the CONFIG_SCSI_TGT, CONFIG_SCSI_SRP_TGT_ATTRS and
> CONFIG_SCSI_FC_TGT_ATTRS kbuild variable[s] [...] are no longer needed".
> It removed the Kconfig entry for SCSI_SRP_TGT_ATTRS, but it left the
> entries for SCSI_TGT and SCSI_FC_TGT_ATTRS untouched.
> 
> 1) Both SCSI_TGT and SCSI_FC_TGT_ATTRS appear to be unused after that
> commit. Is a patch to remove their Kconfig entries queued somewhere?

We missed those two options, feel free to send a patch.

[PATCH] tgt: remove SCSI_TGT and SCSI_FC_TGT_ATTRS

[Paul Bolle]

The Kconfig symbols SCSI_TGT and SCSI_FC_TGT_ATTRS are unused since
commit 73685a458f2e ("tgt: removal"). Setting them has no effect. Remove
these symbols.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Tested by running "make oldconfig" on a Fedora 20 based .config.
That .config has CONFIG_SCSI_TGT set to 'm' and CONFIG_SCSI_FC_TGT_ATTRS
set to 'y'. This patch only makes both symbols disappear from
the .config, which is what we want. Please shout if that's not enough
testing in your opinion.

Note that the commit explanation references a linux-next commit ID. If
that patch gets rebased before entering mainline that won't be a ID
found in the mainline repository anymore!

 drivers/scsi/Kconfig | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 1fa07e4221f7..18a3358eb1d4 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -40,13 +40,6 @@ config SCSI_DMA
 	bool
 	default n
 
-config SCSI_TGT
-	tristate "SCSI target support"
-	depends on SCSI
-	---help---
-	  If you want to use SCSI target mode drivers enable this option.
-	  If you choose M, the module will be called scsi_tgt.
-
 config SCSI_NETLINK
 	bool
 	default	n
@@ -271,13 +264,6 @@ config SCSI_FC_ATTRS
 	  each attached FiberChannel device to sysfs, say Y.
 	  Otherwise, say N.
 
-config SCSI_FC_TGT_ATTRS
-	bool "SCSI target support for FiberChannel Transport Attributes"
-	depends on SCSI_FC_ATTRS
-	depends on SCSI_TGT = y || SCSI_TGT = SCSI_FC_ATTRS
-	help
-		If you want to use SCSI target mode drivers enable this option.
-
 config SCSI_ISCSI_ATTRS
 	tristate "iSCSI Transport Attributes"
 	depends on SCSI && NET
-- 
1.9.3