From: Christoph Hellwig <hch@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
James Bottomely <jbottomley@parallels.com>
Subject: Re: [PATCH 4/4] sd: Handle ZBC drives correctly
Date: Mon, 21 Jul 2014 08:01:09 -0700 [thread overview]
Message-ID: <20140721150109.GB15433@infradead.org> (raw)
In-Reply-To: <53CCFEBE.8080400@suse.de>
On Mon, Jul 21, 2014 at 01:51:26PM +0200, Hannes Reinecke wrote:
> Yes, I have.
How well does the SCSI layer recover when you write outside the write
pointer? ZBC defeinds new sense codes that we don't handle, so I'd
expect we'd get long loops of unrecovered errors.
> I was actually considering implementing a module option for sd
> (eg attach_zbc) to allow zac/zbc devices to be attached to the sd driver.
> Which will be off per default, so your concern should be addressed.
That sounds fine to.
> However, zbc devices _are_ similar to normal 'sd' devices; it's only that
> some commands might fail unexpectedly.
> But all the usual commands from sbc are supported, so I found it a bit odd
> having to implement my own device driver (which would be a clone of 'sd'
> anyway).
They are similar in some ways and very different in others. I
defintively agree we should share as much code as possible, but I'm not
sure exposing them as plain sd devices is a good idea. I'm defintively
fine with an optional attachment to sd to start playing around with
different ways to make use of them.
next prev parent reply other threads:[~2014-07-21 15:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 8:27 [PATCHv2 0/4] Initial SMR drive support Hannes Reinecke
2014-07-21 8:27 ` [PATCH 1/4] libata: consolidate ata_dev_classify() Hannes Reinecke
2014-07-21 8:27 ` [PATCH 2/4] libata: Implement ATA_DEV_ZAC Hannes Reinecke
2014-07-21 8:27 ` [PATCH 3/4] libata-scsi: Update SATL for ZAC drives Hannes Reinecke
2014-07-21 8:27 ` [PATCH 4/4] sd: Handle ZBC drives correctly Hannes Reinecke
2014-07-21 11:29 ` Christoph Hellwig
2014-07-21 11:51 ` Hannes Reinecke
2014-07-21 15:01 ` Christoph Hellwig [this message]
2014-07-21 16:18 ` John Utz
2014-07-21 16:30 ` John Utz
2014-07-21 17:49 ` Hannes Reinecke
2014-07-22 16:19 ` Christoph Hellwig
2014-07-22 18:25 ` John Utz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140721150109.GB15433@infradead.org \
--to=hch@infradead.org \
--cc=hare@suse.de \
--cc=jbottomley@parallels.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).