From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests Date: Thu, 24 Jul 2014 08:34:19 -0700 Message-ID: <20140724153419.GA10372@infradead.org> References: <20140724122223.GA31798@sucs.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: driverdev-devel-bounces@linuxdriverproject.org To: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org, gregkh@linuxfoundation.org, jasowang@redhat.com, linux-kernel@vger.kernel.org, jbottomley@parallels.com, ohering@suse.com, Christoph Hellwig , apw@canonical.com, devel@linuxdriverproject.org, Sitsofe Wheeler List-Id: linux-scsi@vger.kernel.org On Thu, Jul 24, 2014 at 09:54:24AM -0400, Martin K. Petersen wrote: > I'm very much against short-circuiting the LBP logic in a passthrough > driver because then we might end up in the exact situation we were > trying to avoid with this patch series. Namely sending down commands > unsupported by the target device. > > This kind of thing really needs to be a sysadmin decision and can be > handled with a udev rule. I agree - I'd like to pull in KY's simple fix as soon as I get a second review for it.