* [PATCH] scsi: use correct formats in printk()
@ 2014-08-04 8:48 Martin Kepplinger
2014-08-04 10:59 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Martin Kepplinger @ 2014-08-04 8:48 UTC (permalink / raw)
To: ballabio_dario; +Cc: linux-scsi, linux-kernel, Martin Kepplinger
Use %llu for u64 and %u for int. Not the other way round.
Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
applies to -next20140801
drivers/scsi/u14-34f.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/u14-34f.c b/drivers/scsi/u14-34f.c
index 4e76fe8..d8dcf36 100644
--- a/drivers/scsi/u14-34f.c
+++ b/drivers/scsi/u14-34f.c
@@ -1006,7 +1006,7 @@ static int port_detect \
sh[j]->irq, dma_name, sh[j]->sg_tablesize, sh[j]->can_queue);
if (sh[j]->max_id > 8 || sh[j]->max_lun > 8)
- printk("%s: wide SCSI support enabled, max_id %u, max_lun %u.\n",
+ printk("%s: wide SCSI support enabled, max_id %u, max_lun %llu.\n",
BN(j), sh[j]->max_id, sh[j]->max_lun);
for (i = 0; i <= sh[j]->max_channel; i++)
@@ -1285,7 +1285,7 @@ static int u14_34f_queuecommand_lck(struct scsi_cmnd *SCpnt, void (*done)(struct
cpp->cpp_index = i;
SCpnt->host_scribble = (unsigned char *) &cpp->cpp_index;
- if (do_trace) printk("%s: qcomm, mbox %d, target %d.%d:%llu.\n",
+ if (do_trace) printk("%s: qcomm, mbox %d, target %d.%d:%u.\n",
BN(j), i, SCpnt->device->channel, SCpnt->device->id,
(u8)SCpnt->device->lun);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: use correct formats in printk()
2014-08-04 8:48 [PATCH] scsi: use correct formats in printk() Martin Kepplinger
@ 2014-08-04 10:59 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2014-08-04 10:59 UTC (permalink / raw)
To: Martin Kepplinger
Cc: ballabio_dario, linux-scsi, linux-kernel, James Bottomley
On Mon, Aug 04, 2014 at 10:48:37AM +0200, Martin Kepplinger wrote:
> Use %llu for u64 and %u for int. Not the other way round.
I've already queued up an equivalent fix in my core-for-3.17 branch,
I just need James to pull it into the scsi for-next tree.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-04 11:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-04 8:48 [PATCH] scsi: use correct formats in printk() Martin Kepplinger
2014-08-04 10:59 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).