From: Christoph Hellwig <hch@infradead.org>
To: Ari Sundholm <asundhol@cs.hut.fi>
Cc: linux-scsi@vger.kernel.org, Ching Huang <ching2048@areca.com.tw>
Subject: Re: [PATCH] scsi/arcmsr: Add timeout module parameter
Date: Tue, 19 Aug 2014 11:07:54 -0700 [thread overview]
Message-ID: <20140819180754.GB16742@infradead.org> (raw)
In-Reply-To: <alpine.GSO.2.00.1408051559160.13057@hutcs>
On Tue, Aug 05, 2014 at 04:10:08PM +0300, Ari Sundholm wrote:
>
> On Mon, 4 Aug 2014, Christoph Hellwig wrote:
>
> > To modify the timeout on a queue please use blk_queue_rq_timeout in
> > the slave_configure method instead of poking directly into the block
> > timer, which won't work e.g. for the blk-mq path.
>
> I see. It seems the way the driver Areca offers on its download page does
> this is wrong, then, as all I did was I ported the feature from there.
>
> > But this really needs an explanation on why you'd need a configurable
> > timeout to start with.
>
> A colleague of mine has experienced problems with disks not supporting
> TLER performing lengthy error recovery, hitting a timeout. He has
> mitigated this problem by configuring the timeout to be long enough to
> allow for the error recovery to finish. And again, the driver offered by
> Areca supports this feature, so it seems they have their reasons as well.
Can you test this patch:
http://git.infradead.org/users/hch/scsi-queue.git/commitdiff/3a7fcf9e5f57469fab78d6b6db81fbef6fa48a0d
which is part of the latest Areca code drop? I don't really like the
timeout parameter, but if there's no better work around for you we'll
probablyneed to merge something. In that case I'd love a patch ontop of
the branch that the above patches is in, which used the timeout
manipulation method I mentioned in my previous mail.
prev parent reply other threads:[~2014-08-19 18:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-02 19:42 [PATCH] scsi/arcmsr: Add timeout module parameter Ari Sundholm
2014-08-04 11:15 ` Christoph Hellwig
2014-08-05 13:10 ` Ari Sundholm
2014-08-19 18:07 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140819180754.GB16742@infradead.org \
--to=hch@infradead.org \
--cc=asundhol@cs.hut.fi \
--cc=ching2048@areca.com.tw \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).