From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH][SCSI] fix regression in SCSI_IOCTL_SEND_COMMAND Date: Sat, 23 Aug 2014 02:31:00 +0200 Message-ID: <20140823003100.GA16302@lst.de> References: <53F79FBF.4090000@cybernetics.com> <53F7E02B.4070606@interlog.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <53F7E02B.4070606@interlog.com> Sender: linux-kernel-owner@vger.kernel.org To: Douglas Gilbert Cc: Tony Battersby , linux-scsi@vger.kernel.org, "James E.J. Bottomley" , Jens Axboe , linux-kernel@vger.kernel.org, Christoph Hellwig List-Id: linux-scsi@vger.kernel.org On Fri, Aug 22, 2014 at 08:28:27PM -0400, Douglas Gilbert wrote: > To test this ioctl one option is to get the sg3_utils > package and build scsi_ioctl.c in the examples > directory with 'make scsi_ioctl'. > > In lk 3.17-rc1, scsi_ioctl indicates that > SCSI_IOCTL_SEND_COMMAND is not working. In my test applying > this patch fixes the regression. Is there any amount of chocolate or beer that could trick you into adding an automated regression test suite to sg3_utils that could be used to automatically check for regressions like this?