* [patch] xen-scsiback: clean up a type issue in scsiback_make_tpg()
@ 2014-09-08 11:17 Dan Carpenter
2014-09-08 11:31 ` [Xen-devel] " Juergen Gross
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-09-08 11:17 UTC (permalink / raw)
To: Juergen Gross
Cc: Konrad Rzeszutek Wilk, Boris Ostrovsky, David Vrabel, xen-devel,
linux-scsi, kernel-janitors
This code was confusing because we had an unsigned long and then we
compared it to UINT_MAX and then we stored it in a u16. How many bytes
is this supposed to have: 2, 4 or 16???
I've made it a u16 throughout.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c
index 7b565632..ad11258 100644
--- a/drivers/xen/xen-scsiback.c
+++ b/drivers/xen/xen-scsiback.c
@@ -1885,13 +1885,14 @@ scsiback_make_tpg(struct se_wwn *wwn,
struct scsiback_tport, tport_wwn);
struct scsiback_tpg *tpg;
- unsigned long tpgt;
+ u16 tpgt;
int ret;
if (strstr(name, "tpgt_") != name)
return ERR_PTR(-EINVAL);
- if (kstrtoul(name + 5, 10, &tpgt) || tpgt > UINT_MAX)
- return ERR_PTR(-EINVAL);
+ ret = kstrtou16(name + 5, 10, &tpgt);
+ if (ret)
+ return ERR_PTR(ret);
tpg = kzalloc(sizeof(struct scsiback_tpg), GFP_KERNEL);
if (!tpg)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Xen-devel] [patch] xen-scsiback: clean up a type issue in scsiback_make_tpg()
2014-09-08 11:17 [patch] xen-scsiback: clean up a type issue in scsiback_make_tpg() Dan Carpenter
@ 2014-09-08 11:31 ` Juergen Gross
0 siblings, 0 replies; 2+ messages in thread
From: Juergen Gross @ 2014-09-08 11:31 UTC (permalink / raw)
To: Dan Carpenter
Cc: linux-scsi, kernel-janitors, David Vrabel, xen-devel,
Boris Ostrovsky
On 09/08/2014 01:17 PM, Dan Carpenter wrote:
> This code was confusing because we had an unsigned long and then we
> compared it to UINT_MAX and then we stored it in a u16. How many bytes
> is this supposed to have: 2, 4 or 16???
>
> I've made it a u16 throughout.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Thanks,
Juergen
>
> diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c
> index 7b565632..ad11258 100644
> --- a/drivers/xen/xen-scsiback.c
> +++ b/drivers/xen/xen-scsiback.c
> @@ -1885,13 +1885,14 @@ scsiback_make_tpg(struct se_wwn *wwn,
> struct scsiback_tport, tport_wwn);
>
> struct scsiback_tpg *tpg;
> - unsigned long tpgt;
> + u16 tpgt;
> int ret;
>
> if (strstr(name, "tpgt_") != name)
> return ERR_PTR(-EINVAL);
> - if (kstrtoul(name + 5, 10, &tpgt) || tpgt > UINT_MAX)
> - return ERR_PTR(-EINVAL);
> + ret = kstrtou16(name + 5, 10, &tpgt);
> + if (ret)
> + return ERR_PTR(ret);
>
> tpg = kzalloc(sizeof(struct scsiback_tpg), GFP_KERNEL);
> if (!tpg)
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-08 11:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-08 11:17 [patch] xen-scsiback: clean up a type issue in scsiback_make_tpg() Dan Carpenter
2014-09-08 11:31 ` [Xen-devel] " Juergen Gross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox