From: Tejun Heo <tj@kernel.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
Shirish Pargaonkar <shirishpargaonkar@gmail.com>,
Jens Axboe <axboe@kernel.dk>,
SCSI development list <linux-scsi@vger.kernel.org>,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: WARNING in block layer triggered in 3.17-rc3
Date: Wed, 10 Sep 2014 00:17:26 +0900 [thread overview]
Message-ID: <20140909151726.GA8890@mtj.dyndns.org> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1409091026470.1677-100000@iolanthe.rowland.org>
Hello, Alan.
On Tue, Sep 09, 2014 at 11:08:22AM -0400, Alan Stern wrote:
> Sorry, the meaning wasn't clear. I meant that the existing code
> doesn't work. The patch seems to work okay (except that I can't use
> queue_flag_test_and_set because the queue isn't locked at that point).
> I'll submit the patch shortly.
Given it's fully synchronized, the following should work fine and
probably is less misleading than using atomic test_and_set.
if (!blk_queue_init_done) {
queue_flag_set_unlocked(QUEUE_FLAG_INIT_DONE, q);
blk_queue_bypass_end(q);
}
Thanks.
--
tejun
next prev parent reply other threads:[~2014-09-09 15:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 17:45 WARNING in block layer triggered in 3.17-rc3 Alan Stern
2014-09-07 10:43 ` Ming Lei
2014-09-07 22:59 ` Shirish Pargaonkar
2014-09-08 14:51 ` Alan Stern
2014-09-08 15:05 ` Shirish Pargaonkar
2014-09-08 15:51 ` James Bottomley
2014-09-08 16:11 ` Shirish Pargaonkar
2014-09-08 17:42 ` Alan Stern
2014-09-09 1:19 ` Tejun Heo
2014-09-09 15:08 ` Alan Stern
2014-09-09 15:17 ` Tejun Heo [this message]
2014-09-09 15:50 ` [PATCH] Block: fix unbalanced bypass-disable in blk_register_queue Alan Stern
2014-09-09 16:43 ` Tejun Heo
2014-09-09 18:32 ` Shirish Pargaonkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909151726.GA8890@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=shirishpargaonkar@gmail.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox