From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH][SCSI] mpt2sas: fix undefined reference to `__udivdi3' compilation errors Date: Mon, 22 Sep 2014 04:16:33 -0700 Message-ID: <20140922111633.GA31327@infradead.org> References: <1411109247-18184-1-git-send-email-Sreekanth.Reddy@avagotech.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1411109247-18184-1-git-send-email-Sreekanth.Reddy@avagotech.com> Sender: linux-kernel-owner@vger.kernel.org To: Sreekanth Reddy Cc: jejb@kernel.org, hch@infradead.org, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, JBottomley@Parallels.com, Sathya.Prakash@avagotech.com, Nagalakshmi.Nandigama@avagotech.com, linux-kernel@vger.kernel.org, fengguang.wu@intel.com List-Id: linux-scsi@vger.kernel.org Looks good to me. Can I get a quick second review? On Fri, Sep 19, 2014 at 12:17:27PM +0530, Sreekanth Reddy wrote: > This patch will fix the below compilation errors on i386 ARCH > > drivers/built-in.o: In function `_scsih_qcmd': > mpt2sas_scsih.c:(.text+0x1e7b56): undefined reference to `__udivdi3' > mpt2sas_scsih.c:(.text+0x1e7b8a): undefined reference to `__umoddi3' > > Used sector_div() API to fix above compilation errors. > > Signed-off-by: Sreekanth Reddy > --- > drivers/scsi/mpt2sas/mpt2sas_scsih.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mpt2sas_scsih.c > index 992a224..c80ed04 100644 > --- a/drivers/scsi/mpt2sas/mpt2sas_scsih.c > +++ b/drivers/scsi/mpt2sas/mpt2sas_scsih.c > @@ -3860,7 +3860,7 @@ _scsih_setup_direct_io(struct MPT2SAS_ADAPTER *ioc, struct scsi_cmnd *scmd, > struct _raid_device *raid_device, Mpi2SCSIIORequest_t *mpi_request, > u16 smid) > { > - sector_t v_lba, p_lba, stripe_off, stripe_unit, column, io_size; > + sector_t v_lba, p_lba, stripe_off, column, io_size; > u32 stripe_sz, stripe_exp; > u8 num_pds, cmd = scmd->cmnd[0]; > > @@ -3888,9 +3888,9 @@ _scsih_setup_direct_io(struct MPT2SAS_ADAPTER *ioc, struct scsi_cmnd *scmd, > > num_pds = raid_device->num_pds; > p_lba = v_lba >> stripe_exp; > - stripe_unit = p_lba / num_pds; > - column = p_lba % num_pds; > - p_lba = (stripe_unit << stripe_exp) + stripe_off; > + column = sector_div(p_lba, num_pds); > + p_lba = (p_lba << stripe_exp) + stripe_off; > + > mpi_request->DevHandle = cpu_to_le16(raid_device->pd_handle[column]); > > if (cmd == READ_10 || cmd == WRITE_10) > -- > 2.0.2 > ---end quoted text---