From: Christoph Hellwig <hch@infradead.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
linux-scsi <linux-scsi@vger.kernel.org>,
James Bottomley <jbottomley@parallels.com>,
Anish Bhatt <anish@chelsio.com>
Subject: Re: [PATCH] scsi: fix kconfig dependency warnings for SCSI_FC_ATTRS
Date: Mon, 22 Sep 2014 07:42:13 -0700 [thread overview]
Message-ID: <20140922144213.GA28200@infradead.org> (raw)
In-Reply-To: <541CC163.3080709@infradead.org>
On Fri, Sep 19, 2014 at 04:50:59PM -0700, Randy Dunlap wrote:
> --- linux-next-20140918.orig/drivers/scsi/qla2xxx/Kconfig
> +++ linux-next-20140918/drivers/scsi/qla2xxx/Kconfig
> @@ -30,7 +30,7 @@ config SCSI_QLA_FC
>
> config TCM_QLA2XXX
> tristate "TCM_QLA2XXX fabric module for Qlogic 2xxx series target mode HBAs"
> - depends on SCSI_QLA_FC && TARGET_CORE
> + depends on SCSI_QLA_FC && TARGET_CORE && SCSI_FC_ATTRS
CONFIG_SCSI_QLA_FC currently selects SCSI_FC_ATTRS, so we shouldn't
need this here. Also any reason not to switch that one over to a
depends as well?
next prev parent reply other threads:[~2014-09-22 14:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 23:50 [PATCH] scsi: fix kconfig dependency warnings for SCSI_FC_ATTRS Randy Dunlap
2014-09-22 14:42 ` Christoph Hellwig [this message]
2014-09-22 15:49 ` David Miller
2014-09-22 15:56 ` David Miller
2014-09-22 16:44 ` Christoph Hellwig
2014-09-22 16:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140922144213.GA28200@infradead.org \
--to=hch@infradead.org \
--cc=anish@chelsio.com \
--cc=davem@davemloft.net \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox