From: Christoph Hellwig <hch@infradead.org>
To: Saurav Kashyap <saurav.kashyap@qlogic.com>
Cc: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
hch@lst.de, giridhar.malavali@qlogic.com,
andrew.vasquez@qlogic.com
Subject: Re: [PATCH 06/19] qla2xxx: Enable SLER conditionally in target mode.
Date: Thu, 25 Sep 2014 03:14:20 -0700 [thread overview]
Message-ID: <20140925101420.GA305@infradead.org> (raw)
In-Reply-To: <1411632612-7320-7-git-send-email-saurav.kashyap@qlogic.com>
On Thu, Sep 25, 2014 at 04:09:59AM -0400, Saurav Kashyap wrote:
> From: Arun Easi <arun.easi@qlogic.com>
>
> Sequence level error recovery (aka FC Tape) is not really required
> for disk devices. On heavily loaded system, with slow turn around,
> a bunch of status enquiries using REC puts additional burden to the
> target, so just turn off SLER by default.
I don't think a new compile time flag for this is a good idea. I can
put this in under the assumption that it will basically #if 0 out the
code, but a module or sysfs parameter would be more useful if your
intent is that users ever enable it.
next prev parent reply other threads:[~2014-09-25 10:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 8:09 [PATCH 00/19] qla2xxx/target: Target bug fixes and enchancements Saurav Kashyap
2014-09-25 8:09 ` [PATCH 01/19] qla2xxx: Fix sparse warnings in tcm_qla2xxx.c Saurav Kashyap
2014-09-25 8:09 ` [PATCH 02/19] qla2xxx: fix kernel NULL pointer access Saurav Kashyap
2014-09-25 8:09 ` [PATCH 03/19] qla2xxx: Use correct offset to req-q-out for reserve calculation Saurav Kashyap
2014-09-25 8:09 ` [PATCH 04/19] qla2xxx: Increase room in request queue for sending priority packets Saurav Kashyap
2014-09-25 8:09 ` [PATCH 05/19] qla2xxx: Remove verbose messages in target mode Saurav Kashyap
2014-09-25 8:09 ` [PATCH 06/19] qla2xxx: Enable SLER conditionally " Saurav Kashyap
2014-09-25 10:14 ` Christoph Hellwig [this message]
2014-09-25 10:25 ` Saurav Kashyap
2014-09-25 8:10 ` [PATCH 07/19] qla2xxx: Add counter for message Saurav Kashyap
2014-09-25 8:10 ` [PATCH 08/19] qla2xxx: fix crash due to task mgmt cmd type Saurav Kashyap
2014-09-25 8:10 ` [PATCH 09/19] qla2xxx: Add Host reset handling in target mode Saurav Kashyap
2014-09-25 8:10 ` [PATCH 10/19] qla2xxx: Handle chip reset " Saurav Kashyap
2014-09-25 8:10 ` [PATCH 11/19] qla2xxx: Host reset handling in ABTS path Saurav Kashyap
2014-09-25 8:10 ` [PATCH 12/19] qla2xxx: Increase the request queue size to 8K for ISP2031 Saurav Kashyap
2014-09-25 8:10 ` [PATCH 13/19] qla2xxx: Add support for QFull throttling and Term Exchange retry Saurav Kashyap
2014-09-25 8:10 ` [PATCH 14/19] qla2xxx: Do not send SS_RESIDUAL_UNDER with SAM_STAT_BUSY Saurav Kashyap
2014-09-25 8:10 ` [PATCH 15/19] qla2xxx: Fix hang due to cmd_kref not decrementing Saurav Kashyap
2014-09-25 8:10 ` [PATCH 16/19] qla2xxx: Add flags for tracing the target commands Saurav Kashyap
2014-09-25 8:10 ` [PATCH 17/19] qla2xxx: Add memory barrier before ringing doorbell Saurav Kashyap
2014-09-25 8:10 ` [PATCH 18/19] Target/transport: SCSI Status Respond being sent to Initiator twice Saurav Kashyap
2014-09-25 8:10 ` [PATCH 19/19] target: Implement report lun data change unit attention Saurav Kashyap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140925101420.GA305@infradead.org \
--to=hch@infradead.org \
--cc=andrew.vasquez@qlogic.com \
--cc=giridhar.malavali@qlogic.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=saurav.kashyap@qlogic.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox