* [PATCH V2 0/1] Error are logged when application issues illegal request
@ 2014-09-25 19:05 wenxiong
2014-09-25 19:05 ` [PATCH V2 1/1] ipr: Errors " wenxiong
2014-09-26 8:04 ` [PATCH V2 0/1] Error " Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: wenxiong @ 2014-09-25 19:05 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi, brking
Hi Christoph,
Sorry! This patch includes the fix in ipr.h. I built this patch in the
latest scsi tree.
Thanks,
Wendy
--
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH V2 1/1] ipr: Errors are logged when application issues illegal request
2014-09-25 19:05 [PATCH V2 0/1] Error are logged when application issues illegal request wenxiong
@ 2014-09-25 19:05 ` wenxiong
2014-09-26 8:04 ` [PATCH V2 0/1] Error " Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: wenxiong @ 2014-09-25 19:05 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi, brking
[-- Attachment #1: fff4_fix --]
[-- Type: text/plain, Size: 1983 bytes --]
Failing Device information are logged when IOA firmware detected these
illegal request such as IOA firmware doesn't support inquiry with page
code 2. The patch fixes the issue.
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Tested-by: Wen Xiong <wenxiong@linux.vnet.ibm.com>
---
drivers/scsi/ipr.c | 10 ++++++++++
drivers/scsi/ipr.h | 1 +
2 files changed, 11 insertions(+)
Index: b/drivers/scsi/ipr.c
===================================================================
--- a/drivers/scsi/ipr.c 2014-09-23 19:32:26.000000000 -0500
+++ b/drivers/scsi/ipr.c 2014-09-23 19:48:26.179667000 -0500
@@ -2440,6 +2440,7 @@ static void ipr_handle_log_data(struct i
{
u32 ioasc;
int error_index;
+ struct ipr_hostrcb_type_21_error *error;
if (hostrcb->hcam.notify_type != IPR_HOST_RCB_NOTIF_TYPE_ERROR_LOG_ENTRY)
return;
@@ -2464,6 +2465,15 @@ static void ipr_handle_log_data(struct i
if (!ipr_error_table[error_index].log_hcam)
return;
+ if (ioasc == IPR_IOASC_HW_CMD_FAILED &&
+ hostrcb->hcam.overlay_id == IPR_HOST_RCB_OVERLAY_ID_21) {
+ error = &hostrcb->hcam.u.error64.u.type_21_error;
+
+ if (((be32_to_cpu(error->sense_data[0]) & 0x0000ff00) >> 8) == ILLEGAL_REQUEST &&
+ ioa_cfg->log_level <= IPR_DEFAULT_LOG_LEVEL)
+ return;
+ }
+
ipr_hcam_err(hostrcb, "%s\n", ipr_error_table[error_index].error);
/* Set indication we have logged an error */
Index: b/drivers/scsi/ipr.h
===================================================================
--- a/drivers/scsi/ipr.h 2014-09-23 19:32:26.000000000 -0500
+++ b/drivers/scsi/ipr.h 2014-09-25 13:19:43.352079036 -0500
@@ -130,6 +130,7 @@
#define IPR_IOASC_HW_DEV_BUS_STATUS 0x04448500
#define IPR_IOASC_IOASC_MASK 0xFFFFFF00
#define IPR_IOASC_SCSI_STATUS_MASK 0x000000FF
+#define IPR_IOASC_HW_CMD_FAILED 0x046E0000
#define IPR_IOASC_IR_INVALID_REQ_TYPE_OR_PKT 0x05240000
#define IPR_IOASC_IR_RESOURCE_HANDLE 0x05250000
#define IPR_IOASC_IR_NO_CMDS_TO_2ND_IOA 0x05258100
--
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH V2 0/1] Error are logged when application issues illegal request
2014-09-25 19:05 [PATCH V2 0/1] Error are logged when application issues illegal request wenxiong
2014-09-25 19:05 ` [PATCH V2 1/1] ipr: Errors " wenxiong
@ 2014-09-26 8:04 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2014-09-26 8:04 UTC (permalink / raw)
To: wenxiong; +Cc: James.Bottomley, linux-scsi, brking
On Thu, Sep 25, 2014 at 02:05:14PM -0500, wenxiong@linux.vnet.ibm.com wrote:
>
> Hi Christoph,
>
> Sorry! This patch includes the fix in ipr.h. I built this patch in the
> latest scsi tree.
I've insted just applied the typo fix as I didn't want to rebase.
Can you cross check:
http://git.infradead.org/users/hch/scsi-queue.git/shortlog/refs/heads/drivers-for-3.18
for me please?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-26 8:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-25 19:05 [PATCH V2 0/1] Error are logged when application issues illegal request wenxiong
2014-09-25 19:05 ` [PATCH V2 1/1] ipr: Errors " wenxiong
2014-09-26 8:04 ` [PATCH V2 0/1] Error " Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox