* re: ufs: Add support for clock gating
@ 2014-10-02 15:30 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2014-10-02 15:30 UTC (permalink / raw)
To: stummala; +Cc: linux-scsi
Hello Sahitya Tummala,
The patch 1ab27c9cf8b6: "ufs: Add support for clock gating" from Sep
25, 2014, leads to the following static checker warning:
drivers/scsi/ufs/ufshcd.c:4474 __ufshcd_setup_clocks()
warn: we tested 'ret' before and it was 'false'
drivers/scsi/ufs/ufshcd.c
4467 ret = hba->vops->setup_clocks(hba, on);
4468 out:
4469 if (ret) {
4470 list_for_each_entry(clki, head, list) {
4471 if (!IS_ERR_OR_NULL(clki->clk) && clki->enabled)
4472 clk_disable_unprepare(clki->clk);
4473 }
4474 } else if (!ret && on) {
^^^^
Not needed.
4475 spin_lock_irqsave(hba->host->host_lock, flags);
4476 hba->clk_gating.state = CLKS_ON;
4477 spin_unlock_irqrestore(hba->host->host_lock, flags);
4478 }
4479 return ret;
4480 }
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-10-02 15:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-02 15:30 ufs: Add support for clock gating Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox