From: "Luis R. Rodriguez" <mcgrof@suse.com>
To: Tejun Heo <tj@kernel.org>
Cc: gregkh@linuxfoundation.org,
"Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
dmitry.torokhov@gmail.com, tiwai@suse.de, arjan@linux.intel.com,
teg@jklm.no, rmilasan@suse.com, werner@suse.com, oleg@redhat.com,
hare@suse.com, bpoirier@suse.de, santosh@chelsio.com,
pmladek@suse.cz, dbueso@suse.com, linux-kernel@vger.kernel.org,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Joseph Salisbury <joseph.salisbury@canonical.com>,
Kay Sievers <kay@vrfy.org>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Tim Gardner <tim.gardner@canonical.com>,
Pierre Fersing <pierre-fersing@pierref.org>,
Andrew Morton <akpm@linux-foundation.org>,
Nagalakshmi Nandigama <nagalakshmi.nandigama@avagotech.com>,
Praveen Krishnamoorthy <praveen.krishnamoorthy@avagotech.com>,
Sreekanth Reddy <sreekanth.reddy@avagotech.com>,
Abhijit Mahajan <abhijit.mahajan@avagotech.com>,
Casey Leedom <leedom@che>
Subject: Re: [PATCH v1 5/5] driver-core: add driver asynchronous probe support
Date: Fri, 3 Oct 2014 01:29:44 +0200 [thread overview]
Message-ID: <20141002232944.GT14081@wotan.suse.de> (raw)
In-Reply-To: <20140930072159.GC14081@wotan.suse.de>
On Tue, Sep 30, 2014 at 09:21:59AM +0200, Luis R. Rodriguez wrote:
> On Mon, Sep 29, 2014 at 05:26:01PM -0400, Tejun Heo wrote:
> > Hello, Luis.
> >
> > On Mon, Sep 29, 2014 at 11:22:08PM +0200, Luis R. Rodriguez wrote:
> > > > > + /* For now lets avoid stupid bug reports */
> > > > > + if (!strcmp(bus->name, "pci") ||
> > > > > + !strcmp(bus->name, "pci_express") ||
> > > > > + !strcmp(bus->name, "hid") ||
> > > > > + !strcmp(bus->name, "sdio") ||
> > > > > + !strcmp(bus->name, "gameport") ||
> > > > > + !strcmp(bus->name, "mmc") ||
> > > > > + !strcmp(bus->name, "i2c") ||
> > > > > + !strcmp(bus->name, "platform") ||
> > > > > + !strcmp(bus->name, "usb"))
> > > > > + return true;
> > > >
> > > > Ugh... things like this tend to become permanent. Do we really need
> > > > this? And how are we gonna find out what's broken why w/o bug
> > > > reports?
> > >
> > > Yeah... well we have two options, one is have something like this to
> > > at least make it generally useful or remove this and let folks who
> > > care start fixing async for all modules. The downside to removing
> > > this is it makes async probe pretty much useless on most systems
> > > right now, it would mean systemd would have to probably consider
> > > the list above if they wanted to start using this without expecting
> > > systems to not work.
> >
> > So, I'd much prefer blacklist approach if something like this is a
> > necessity. That way, we'd at least know what doesn't work.
>
> For buses? Or do you mean you'd want to wait until we have a decent
> list of drivers with the sync probe flag set? If the later it may take
> a while to get that list for this to be somewhat useful.
OK I'm removing this part and it works well for me now on my laptop
and an AMD server without a white list, so all the junk above will
be removed in the next series.
Luis
next prev parent reply other threads:[~2014-10-02 23:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1411768637-6809-1-git-send-email-mcgrof@do-not-panic.com>
2014-09-26 21:57 ` [PATCH v1 5/5] driver-core: add driver asynchronous probe support Luis R. Rodriguez
2014-09-28 15:03 ` Tejun Heo
2014-09-29 21:22 ` Luis R. Rodriguez
2014-09-29 21:26 ` Tejun Heo
2014-09-30 7:21 ` Luis R. Rodriguez
2014-10-02 23:29 ` Luis R. Rodriguez [this message]
2014-09-29 21:59 ` Greg KH
2014-09-29 22:10 ` Luis R. Rodriguez
2014-09-29 22:24 ` Greg KH
2014-09-28 17:07 ` Tom Gundersen
2014-09-30 2:27 ` Luis R. Rodriguez
2014-09-30 7:47 ` Luis R. Rodriguez
2014-09-30 9:22 ` Tom Gundersen
2014-09-30 15:24 ` Luis R. Rodriguez
2014-10-02 6:12 ` Tom Gundersen
2014-10-02 20:06 ` Luis R. Rodriguez
2014-10-03 8:23 ` Tom Gundersen
2014-10-03 16:54 ` Luis R. Rodriguez
2014-09-28 19:22 ` Dmitry Torokhov
2014-09-30 7:15 ` Luis R. Rodriguez
2014-10-02 23:31 ` Luis R. Rodriguez
2014-10-03 20:11 ` Luis R. Rodriguez
2014-10-03 21:12 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141002232944.GT14081@wotan.suse.de \
--to=mcgrof@suse.com \
--cc=abhijit.mahajan@avagotech.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=bpoirier@suse.de \
--cc=dbueso@suse.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.com \
--cc=joseph.salisbury@canonical.com \
--cc=kay@vrfy.org \
--cc=leedom@che \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
--cc=nagalakshmi.nandigama@avagotech.com \
--cc=oleg@redhat.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=pierre-fersing@pierref.org \
--cc=pmladek@suse.cz \
--cc=praveen.krishnamoorthy@avagotech.com \
--cc=rmilasan@suse.com \
--cc=santosh@chelsio.com \
--cc=sreekanth.reddy@avagotech.com \
--cc=teg@jklm.no \
--cc=tim.gardner@canonical.com \
--cc=tiwai@suse.de \
--cc=tj@kernel.org \
--cc=werner@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox