* [PATCH] Fix comment typo in Scsi_Host struct definition
@ 2014-10-09 11:40 Mark Knibbs
2014-10-17 13:24 ` Christoph Hellwig
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Mark Knibbs @ 2014-10-09 11:40 UTC (permalink / raw)
To: linux-scsi
Hi,
The comment for the max_channel, max_id and max_lun parameters
refers to the first two, but actually means the last two.
Signed-off-by: Mark Knibbs <markk@clara.co.uk>
---
$ diff -upN linux-3.17/include/scsi/scsi_host.h.orig linux-3.17/include/scsi/scsi_host.h
--- linux-3.17/include/scsi/scsi_host.h.orig 2014-10-05 20:23:04.000000000 +0100
+++ linux-3.17/include/scsi/scsi_host.h 2014-10-09 12:18:47.000000000 +0100
@@ -606,7 +606,7 @@ struct Scsi_Host {
/*
* These three parameters can be used to allow for wide scsi,
* and for host adapters that support multiple busses
- * The first two should be set to 1 more than the actual max id
+ * The last two should be set to 1 more than the actual max id
* or lun (e.g. 8 for SCSI parallel systems).
*/
unsigned int max_channel;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Fix comment typo in Scsi_Host struct definition
2014-10-09 11:40 [PATCH] Fix comment typo in Scsi_Host struct definition Mark Knibbs
@ 2014-10-17 13:24 ` Christoph Hellwig
2014-10-17 23:31 ` Martin K. Petersen
2014-10-21 11:25 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2014-10-17 13:24 UTC (permalink / raw)
To: Mark Knibbs; +Cc: linux-scsi
On Thu, Oct 09, 2014 at 12:40:07PM +0100, Mark Knibbs wrote:
> Hi,
>
> The comment for the max_channel, max_id and max_lun parameters
> refers to the first two, but actually means the last two.
>
> Signed-off-by: Mark Knibbs <markk@clara.co.uk>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix comment typo in Scsi_Host struct definition
2014-10-09 11:40 [PATCH] Fix comment typo in Scsi_Host struct definition Mark Knibbs
2014-10-17 13:24 ` Christoph Hellwig
@ 2014-10-17 23:31 ` Martin K. Petersen
2014-10-21 11:25 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2014-10-17 23:31 UTC (permalink / raw)
To: Mark Knibbs; +Cc: linux-scsi
>>>>> "Mark" == Mark Knibbs <markk@clara.co.uk> writes:
Mark> The comment for the max_channel, max_id and max_lun parameters
Mark> refers to the first two, but actually means the last two.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix comment typo in Scsi_Host struct definition
2014-10-09 11:40 [PATCH] Fix comment typo in Scsi_Host struct definition Mark Knibbs
2014-10-17 13:24 ` Christoph Hellwig
2014-10-17 23:31 ` Martin K. Petersen
@ 2014-10-21 11:25 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2014-10-21 11:25 UTC (permalink / raw)
To: Mark Knibbs; +Cc: linux-scsi
On Thu, Oct 09, 2014 at 12:40:07PM +0100, Mark Knibbs wrote:
> Hi,
>
> The comment for the max_channel, max_id and max_lun parameters
> refers to the first two, but actually means the last two.
>
> Signed-off-by: Mark Knibbs <markk@clara.co.uk>
I just noticed that I have already applied an equal patch from
Sebastian Herbszt, so I'll skip your version.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-21 11:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-09 11:40 [PATCH] Fix comment typo in Scsi_Host struct definition Mark Knibbs
2014-10-17 13:24 ` Christoph Hellwig
2014-10-17 23:31 ` Martin K. Petersen
2014-10-21 11:25 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox