From: Christoph Hellwig <hch@infradead.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Brian King <brking@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org, wenxiong@linux.vnet.ibm.com
Subject: Re: [PATCH 1/2] ipr: Disable async aborts
Date: Tue, 28 Oct 2014 01:47:16 -0700 [thread overview]
Message-ID: <20141028084716.GA14286@infradead.org> (raw)
In-Reply-To: <1414421403.6401.5.camel@jarvis.lan>
On Mon, Oct 27, 2014 at 07:50:03AM -0700, James Bottomley wrote:
> On Mon, 2014-10-27 at 09:37 -0500, Brian King wrote:
> > The ipr driver does not yet support async aborts, so disable this
> > for now.
> >
> > Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
>
> By "does not yet support" do you mean doesn't work with or merely not
> tested with but seems to work OK? if the former, then surely this
> should be a fixes patch with a cc to stable for all the kernels async
> abort is in (which is 3.14)
I'm pretty sure this patch is incorrect, and that what ever issue should
have been described in this patch are the same EH problems we fixed in
the last couple releases. I've also talked to Hannes a while ago, and
we agree that we want to remove this flag ASAP as it's inviting this
next prev parent reply other threads:[~2014-10-28 8:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 14:37 [PATCH 1/2] ipr: Disable async aborts Brian King
2014-10-27 14:50 ` James Bottomley
2014-10-28 8:47 ` Christoph Hellwig [this message]
2014-10-29 21:16 ` Brian King
2014-10-30 8:17 ` Christoph Hellwig
2014-10-28 13:58 ` Brian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141028084716.GA14286@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=brking@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=wenxiong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox