Re: [PATCH 1/2] scsi: TUR path is down after adapter gets reset in multipath configuration(scsi_error.c)

[Christoph Hellwig <hch@infradead.org>]

On Mon, Oct 27, 2014 at 01:01:48PM -0500, wenxiong@linux.vnet.ibm.com wrote:
> After an ipr adapter gets reset, all disk array devices require a start
> unit command to be issued to them before they will accept commands. So,
> with the SCSI EH change, we now end up in a scenario with dual ipr
> adapters where the TUR getting issued from the health checker returns
> with a Not Ready response and since SCSI EH no longer triggers the Start
> Unit in this scenario, the path never recovers.
> 
> Signed-off-by: Christoph Hellwig <hch@infradead.org>
> Tested-by: Wen Xiong <wenxiong@linux.vnet.ibm.com>

Th patch description is entirely wrong, but I guess I'll have to
take the blame for that as it's my patch.  How about something like:

From: Christoph Hellwig <hch@infradead.org>
Subject: scsi: call device handler for failed TUR command

Multipath devices using the TUR path checker need to see the sense
code for a failed TUR command in their device handler.  Since commit
<insert commit id here> we always return success for mid layer issued
TUR commands before calling the device handler, which stopped the
TUR path checker from working.

Move the call to the device handler check sense method before the early
return for TUR commands to give the device handler a chance to intercept
them.

Signed-off-by: Christoph Hellwig <hch@infradead.org>
Tested-by: Wen Xiong <wenxiong@linux.vnet.ibm.com>