From: Christoph Hellwig <hch@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: James Bottomley <jbottomley@parallels.com>,
Christoph Hellwig <hch@infradead.org>,
Ewan Milne <emilne@redhat.com>, Robert Elliott <elliott@hp.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 3/3] scsi: make asynchronous aborts mandatory
Date: Tue, 4 Nov 2014 10:52:49 -0800 [thread overview]
Message-ID: <20141104185249.GA30233@infradead.org> (raw)
In-Reply-To: <1415103073-90276-4-git-send-email-hare@suse.de>
This leaves a stale comment reference to scsi_eh_abort_cmds in libsas.
Also while grepping for that I found out that sas aborts don't work
anymore with the async abort code due to this beautiful code in
sas_eh_abort_handler:
if (current != host->ehandler)
return FAILED;
so you'll need another patch to fix that up. In the longer run we
really should both kill sas_eh_abort_handler and bring SAS EH
more in line with the rest of the world.
prev parent reply other threads:[~2014-11-04 18:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 12:11 [RFC PATCH 0/3] scsi: make asynchronous aborts mandatory Hannes Reinecke
2014-11-04 12:11 ` [PATCH 1/3] scsi: make scsi_eh_scmd_add() always succeed Hannes Reinecke
2014-11-04 18:36 ` Christoph Hellwig
2014-11-05 7:44 ` Hannes Reinecke
2014-11-04 12:11 ` [PATCH 2/3] scsi: make eh_eflags persistent Hannes Reinecke
2014-11-04 12:11 ` [PATCH 3/3] scsi: make asynchronous aborts mandatory Hannes Reinecke
2014-11-04 18:52 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141104185249.GA30233@infradead.org \
--to=hch@infradead.org \
--cc=elliott@hp.com \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox