From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@canonical.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
James Bottomley <JBottomley@parallels.com>,
Jens Axboe <axboe@kernel.dk>,
Linux SCSI List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 2/2] virtio_scsi: support multi hw queue of blk-mq
Date: Mon, 10 Nov 2014 17:05:06 +0100 [thread overview]
Message-ID: <20141110160506.GB15315@lst.de> (raw)
In-Reply-To: <CACVXFVMdUVfXNoC0FDhmaQtxehCBgG3xnTx-PJ3BmoQaT1LsoQ@mail.gmail.com>
On Mon, Nov 10, 2014 at 10:25:43PM +0800, Ming Lei wrote:
> It depends on how long the transition period is, and other drivers
> with multi hwq support might be in the same situation with virtio-scsi. If
> the period is a bit long, it would be painful for these drivers to support
> both blk-mq and non-mq.
If it's too long we need to find better ways to control the behavior. But
honestly I'd rather prefer to keep selected drivers on the old code for
that case than the other way around.
We currently still have two big blockers for having any sort of real
blk-mq by default decision for scsi:
a) there is no multiath support for it, and we simply can't break existing
setups that use.
b) there is no support for I/O schedulers at all. This might be okay
for virtio-scsi, where in general you have a host scheduler, but for
real hardware that still has to deal with more spinning rust than
solid state it's a blocker. Fortuntely Jens is working on that one.
> Also with force_blk_mq on virtio-scsi, people can test scsi-mq with
> default setting, then it should be helpful to collect more test reports, :-)
I think between the config and the module/boot option we've already got
ways to get reports. Improvements welcome.
next prev parent reply other threads:[~2014-11-10 16:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-09 16:57 [PATCH 0/2] virtio_scsi: support multi hw queue of blk-mq Ming Lei
2014-11-09 16:57 ` [PATCH 1/2] scsi: introduce force_blk_mq Ming Lei
2014-11-09 16:57 ` [PATCH 2/2] virtio_scsi: support multi hw queue of blk-mq Ming Lei
2014-11-10 10:41 ` Paolo Bonzini
2014-11-10 13:39 ` Christoph Hellwig
2014-11-10 14:25 ` Ming Lei
2014-11-10 16:05 ` Christoph Hellwig [this message]
2014-11-11 17:09 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141110160506.GB15315@lst.de \
--to=hch@lst.de \
--cc=JBottomley@parallels.com \
--cc=axboe@kernel.dk \
--cc=linux-scsi@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox