linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	Wendy Xiong <wenxiong@linux.vnet.ibm.com>,
	kexec@lists.infradead.org
Subject: Re: [PATCH 3/5]: ipr: kexec boot speed improvements
Date: Mon, 1 Dec 2014 07:43:19 +1100	[thread overview]
Message-ID: <20141201074319.7ded3d8e@kryten> (raw)
In-Reply-To: <20140827140630.1f0ee455@kryten>

Hi Brian,

> > Currently when performing a kexec boot with an ipr adapter,
> > the adapter gets shutdown completely, flushing all write
> > cache, as well as performing a full hardware reset of the card
> > during the shutdown phase of the old kernel. This forces
> > the new kernel to then wait for the adapter firmware to
> > reinitialize, which slows down kexec boot. There is no
> > need to do all of this on the newer ipr adapters, since they
> > support the ability to cancel outstanding error buffers.
> > 
> > This patch adds a special case for kexec boot to simply
> > cancel these outstanding error buffers, and as long as
> > there is no other I/O outstanding to the adapter, which
> > there shouldn't be, place the adapter into a state
> > where it has no memory of any DMA addresses from the old
> > kernel, then disable the device. This significantly
> > speeds up kexec boot, particularly in configurations with
> > multiple ipr adapters.
> > 
> > Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
> > ---
> 
> This reduces boot time on my box from 80 seconds to 34 seconds. ppc64
> kernel developers (who boot boxes continually) thank you!
> 
> Tested-by: Anton Blanchard <anton@samba.org>

Just checking on this series. I'm very keen to see it go in since it is
a huge improvement in boot time.

Anton

      reply	other threads:[~2014-11-30 20:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-28 20:29 [PATCH 3/5]: ipr: kexec boot speed improvements Brian King
2014-08-27  4:06 ` Anton Blanchard
2014-11-30 20:43   ` Anton Blanchard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141201074319.7ded3d8e@kryten \
    --to=anton@samba.org \
    --cc=JBottomley@parallels.com \
    --cc=brking@linux.vnet.ibm.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=wenxiong@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).