linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
	linux-scsi@vger.kernel.org, Doug Ledford <dledford@redhat.com>
Subject: Re: [PATCH 1/4] scsi: remove ->change_queue_type method
Date: Thu, 4 Dec 2014 10:10:44 +0100	[thread overview]
Message-ID: <20141204091044.GA23870@lst.de> (raw)
In-Reply-To: <547F10D4.60605@suse.de>

On Wed, Dec 03, 2014 at 02:32:04PM +0100, Hannes Reinecke wrote:
> Why not setting the attribute to S_IRUGO always and drop the 'store'
> method altogether?

For now I'm printing a warning if someone writes to it.  I the long
run we can simply mark it r/o.


  reply	other threads:[~2014-12-04  9:10 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-24 14:36 queue_type fixups Christoph Hellwig
2014-11-24 14:36 ` [PATCH 1/4] scsi: remove ->change_queue_type method Christoph Hellwig
2014-11-28  9:59   ` Bart Van Assche
2014-12-03 13:32   ` Hannes Reinecke
2014-12-04  9:10     ` Christoph Hellwig [this message]
2014-12-04  2:27   ` Martin K. Petersen
2014-11-24 14:36 ` [PATCH 2/4] scsi: never drop to untagged mode during queue ramp down Christoph Hellwig
2014-11-28  9:59   ` Bart Van Assche
2014-12-03 13:32   ` Hannes Reinecke
2014-12-04  2:28   ` Martin K. Petersen
2014-11-24 14:36 ` [PATCH 3/4] scsi: remove scsi_get_tag_type Christoph Hellwig
2014-11-28 10:00   ` Bart Van Assche
2014-12-03 13:33   ` Hannes Reinecke
2014-12-04  2:28   ` Martin K. Petersen
2014-11-24 14:36 ` [PATCH 4/4] scsi: remove scsi_set_tag_type Christoph Hellwig
2014-11-28 10:00   ` Bart Van Assche
2014-12-03 13:34   ` Hannes Reinecke
2014-12-04  2:29   ` Martin K. Petersen
2014-11-24 15:07 ` [PATCH 5/4] scsi: remove MSG_*_TAG defines Christoph Hellwig
2014-11-28  9:58   ` Bart Van Assche
2014-12-01  9:03     ` Christoph Hellwig
2014-12-01 11:44       ` Bart Van Assche
2014-12-04  2:31   ` Martin K. Petersen
2014-12-03  9:32 ` queue_type fixups Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141204091044.GA23870@lst.de \
    --to=hch@lst.de \
    --cc=dledford@redhat.com \
    --cc=hare@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).