From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: James Bottomley <jbottomley@parallels.com>,
Christoph Hellwig <hch@lst.de>, Matthew Wilcox <matthew@wil.cx>,
Doug Gilbert <dgilbert@interlog.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 01/12] advansys: use host_reset
Date: Thu, 4 Dec 2014 10:17:41 +0100 [thread overview]
Message-ID: <20141204091741.GC23891@lst.de> (raw)
In-Reply-To: <1417607105-85455-2-git-send-email-hare@suse.de>
> -#define AdvAbortQueue(asc_dvc, scsiq) \
> +#define AdvAbortQueue(asc_dvc, srb_tag) \
> AdvSendIdleCmd((asc_dvc), (ushort) IDLE_CMD_ABORT, \
> - (ADV_DCNT) (scsiq))
> + (ADV_DCNT) (srb_tag))
This change looks unrelated.
> @@ -11250,7 +11250,7 @@ static struct scsi_host_template advansys_template = {
> .name = DRV_NAME,
> .info = advansys_info,
> .queuecommand = advansys_queuecommand,
> - .eh_bus_reset_handler = advansys_reset,
> + .eh_host_reset_handler = advansys_reset,
Please also update the comments in advansys_reset that talk about bus
resets and in one case event about a device reset.
next prev parent reply other threads:[~2014-12-04 9:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 11:44 [PATCH 00/12] nobody loves the advansys driver Hannes Reinecke
2014-12-03 11:44 ` [PATCH 01/12] advansys: use host_reset Hannes Reinecke
2014-12-04 9:17 ` Christoph Hellwig [this message]
2014-12-04 9:23 ` Hannes Reinecke
2014-12-03 11:44 ` [PATCH 02/12] advansys: use shared host tag map for command lookup Hannes Reinecke
2014-12-04 9:20 ` Christoph Hellwig
2014-12-04 9:25 ` Hannes Reinecke
2014-12-04 9:26 ` Christoph Hellwig
2014-12-03 11:44 ` [PATCH 03/12] advansys: use DMA-API for mapping sense buffer Hannes Reinecke
2014-12-03 11:44 ` [PATCH 04/12] advansys: Use DMA-API for carrier buffer Hannes Reinecke
2014-12-03 11:44 ` [PATCH 05/12] advansys: Use DMA-API for mapping request blocks Hannes Reinecke
2014-12-03 11:44 ` [PATCH 06/12] advansys: Use dma_pool for sg elements Hannes Reinecke
2014-12-03 11:45 ` [PATCH 07/12] advansys: use 'bool' instead of 'int' Hannes Reinecke
2014-12-03 11:45 ` [PATCH 08/12] advansys: use standard data types Hannes Reinecke
2014-12-03 11:45 ` [PATCH 09/12] advansys: Remove 'TRUE' and 'FALSE' definitions Hannes Reinecke
2014-12-03 11:45 ` [PATCH 10/12] advansys: Remove 'ERR' definition Hannes Reinecke
2014-12-03 11:45 ` [PATCH 11/12] advansys: cleanup function return codes Hannes Reinecke
2014-12-03 11:45 ` [PATCH 12/12] advansys: Update to version 3.5 and remove compilation warning Hannes Reinecke
2014-12-04 9:23 ` Christoph Hellwig
2014-12-04 9:26 ` Hannes Reinecke
2014-12-03 15:21 ` [PATCH 00/12] nobody loves the advansys driver Christoph Hellwig
2014-12-03 15:34 ` Ondrej Zary
2014-12-03 15:42 ` James Bottomley
2014-12-03 16:28 ` Hannes Reinecke
2014-12-04 9:13 ` hch
2014-12-04 9:12 ` Christoph Hellwig
2014-12-03 16:06 ` Douglas Gilbert
2014-12-03 18:29 ` Ondrej Zary
2014-12-04 7:12 ` Hannes Reinecke
2014-12-07 14:44 ` Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141204091741.GC23891@lst.de \
--to=hch@lst.de \
--cc=dgilbert@interlog.com \
--cc=hare@suse.de \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).