From: Ondrej Zary <linux@rainbow-software.org>
To: Hannes Reinecke <hare@suse.de>
Cc: James Bottomley <jbottomley@parallels.com>,
Christoph Hellwig <hch@lst.de>, Matthew Wilcox <matthew@wil.cx>,
Doug Gilbert <dgilbert@interlog.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 00/12] nobody loves the advansys driver
Date: Sun, 7 Dec 2014 15:44:24 +0100 [thread overview]
Message-ID: <201412071544.25049.linux@rainbow-software.org> (raw)
In-Reply-To: <54800975.2050606@suse.de>
On Thursday 04 December 2014 08:12:53 Hannes Reinecke wrote:
> On 12/03/2014 07:29 PM, Ondrej Zary wrote:
> > On Wednesday 03 December 2014 12:44:53 Hannes Reinecke wrote:
> >> Hi all,
> >>
> >> it has been bugged me for ages that the advansys driver always
> >> reported a compilation warning about not having been converted
> >> to the DMA-API.
> >> And even aggressive waiting hasn't made this warning go away.
> >>
> >> So here's a patchset to update the advansys driver to current
> >> standards and use the DMA-API.
> >> Tested on ABP940-U2W.
> >>
> >> As usual, reviews and comments are welcome.
> >>
> >> Hannes Reinecke (12):
> >> advansys: use host_reset
> >> advansys: use shared host tag map for command lookup
> >> advansys: use DMA-API for mapping sense buffer
> >> advansys: Use DMA-API for carrier buffer
> >> advansys: Use DMA-API for mapping request blocks
> >> advansys: Use dma_pool for sg elements
> >> advansys: use 'bool' instead of 'int'
> >> advansys: use standard data types
> >> advansys: Remove 'TRUE' and 'FALSE' definitions
> >> advansys: Remove 'ERR' definition
> >> advansys: cleanup function return codes
> >> advansys: Update to version 3.5 and remove compilation warning
> >>
> >> MAINTAINERS | 1 +
> >> drivers/scsi/advansys.c | 1073
> >> +++++++++++++++++++++-------------------------- 2 files changed, 469
> >> insertions(+), 605 deletions(-)
> >
> > Seems to break narrow boards, at least mine ASB-3940UA :(
> >
> > [ 4.266292] ACPI: PCI Interrupt Link [LNKC] enabled at IRQ 9
> > [ 7.661374] scsi host2: AdvanSys SCSI 3.5: PCI Ultra: IO
> > 0xA800-0xA80F, IRQ 0x9 [ 28.840078] scsi 2:0:0:0: SCSI bus reset
> > started...
> > [ 28.846640] scsi 2:0:0:0: SCSI bus reset error: 0x2, status: 0x0
> > [ 28.846648] scsi 2:0:0:0: Device offlined - not ready after error
> > recovery [ 28.846803] scsi 2:0:1:0: ExeScsiQueue() ASC_ERROR, err_code
> > 0x2 [ 28.852052] scsi 2:0:1:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [
> > 28.860051] scsi 2:0:1:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [
> > 28.868047] scsi 2:0:1:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [
> > 28.868249] scsi 2:0:2:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [
> > 28.876050] scsi 2:0:2:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [
> > 28.884048] scsi 2:0:2:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [
> > 28.892047] scsi 2:0:2:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [
> > 28.892243] scsi 2:0:3:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [
> > 28.900051] scsi 2:0:3:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [
> > 28.908048] scsi 2:0:3:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [
> > 28.916047] scsi 2:0:3:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [
> > 28.916241] scsi 2:0:4:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [
> > 28.924051] scsi 2:0:4:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [
> > 28.932048] scsi 2:0:4:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [
> > 28.940048] scsi 2:0:4:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [
> > 28.940240] scsi 2:0:5:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [
> > 28.948051] scsi 2:0:5:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [
> > 28.956049] scsi 2:0:5:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [
> > 28.964047] scsi 2:0:5:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [
> > 28.964239] scsi 2:0:6:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [
> > 28.972050] scsi 2:0:6:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [
> > 28.980048] scsi 2:0:6:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [
> > 28.988050] scsi 2:0:6:0: ExeScsiQueue() ASC_ERROR, err_code 0x2
> >
> > Before the patch:
> > [ 4.226690] ACPI: PCI Interrupt Link [LNKC] enabled at IRQ 9
> > [ 7.644841] scsi host2: AdvanSys SCSI 3.4: PCI Ultra: IO
> > 0xA800-0xA80F, IRQ 0x9 [ 8.072257] scsi 2:0:2:0: Processor HP
> > C1790A 3226 PQ: 0 ANSI: 2 [ 8.919128] scsi 2:0:2:0:
> > Attached scsi generic sg3 type 3
>
> Right. So _this_ was the mysterious command about srb_tag '0' being
> reserved. Can you try with this patch?
Thanks, it fixes the problem.
--
Ondrej Zary
prev parent reply other threads:[~2014-12-07 14:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 11:44 [PATCH 00/12] nobody loves the advansys driver Hannes Reinecke
2014-12-03 11:44 ` [PATCH 01/12] advansys: use host_reset Hannes Reinecke
2014-12-04 9:17 ` Christoph Hellwig
2014-12-04 9:23 ` Hannes Reinecke
2014-12-03 11:44 ` [PATCH 02/12] advansys: use shared host tag map for command lookup Hannes Reinecke
2014-12-04 9:20 ` Christoph Hellwig
2014-12-04 9:25 ` Hannes Reinecke
2014-12-04 9:26 ` Christoph Hellwig
2014-12-03 11:44 ` [PATCH 03/12] advansys: use DMA-API for mapping sense buffer Hannes Reinecke
2014-12-03 11:44 ` [PATCH 04/12] advansys: Use DMA-API for carrier buffer Hannes Reinecke
2014-12-03 11:44 ` [PATCH 05/12] advansys: Use DMA-API for mapping request blocks Hannes Reinecke
2014-12-03 11:44 ` [PATCH 06/12] advansys: Use dma_pool for sg elements Hannes Reinecke
2014-12-03 11:45 ` [PATCH 07/12] advansys: use 'bool' instead of 'int' Hannes Reinecke
2014-12-03 11:45 ` [PATCH 08/12] advansys: use standard data types Hannes Reinecke
2014-12-03 11:45 ` [PATCH 09/12] advansys: Remove 'TRUE' and 'FALSE' definitions Hannes Reinecke
2014-12-03 11:45 ` [PATCH 10/12] advansys: Remove 'ERR' definition Hannes Reinecke
2014-12-03 11:45 ` [PATCH 11/12] advansys: cleanup function return codes Hannes Reinecke
2014-12-03 11:45 ` [PATCH 12/12] advansys: Update to version 3.5 and remove compilation warning Hannes Reinecke
2014-12-04 9:23 ` Christoph Hellwig
2014-12-04 9:26 ` Hannes Reinecke
2014-12-03 15:21 ` [PATCH 00/12] nobody loves the advansys driver Christoph Hellwig
2014-12-03 15:34 ` Ondrej Zary
2014-12-03 15:42 ` James Bottomley
2014-12-03 16:28 ` Hannes Reinecke
2014-12-04 9:13 ` hch
2014-12-04 9:12 ` Christoph Hellwig
2014-12-03 16:06 ` Douglas Gilbert
2014-12-03 18:29 ` Ondrej Zary
2014-12-04 7:12 ` Hannes Reinecke
2014-12-07 14:44 ` Ondrej Zary [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201412071544.25049.linux@rainbow-software.org \
--to=linux@rainbow-software.org \
--cc=dgilbert@interlog.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).