* [PATCH] uas: disable UAS on Apricorn SATA dongles
@ 2014-12-11 19:01 Darrick J. Wong
[not found] ` <20141211190111.GD21955-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Darrick J. Wong @ 2014-12-11 19:01 UTC (permalink / raw)
To: Hans de Goede
Cc: Gerd Hoffmann, linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-scsi-u79uwXL29TY76Z2rM5mHXA,
usb-storage-ijkIwGHArpdIPJnuZ7Njw4oP9KaGy4wf
The Apricorn SATA dongle will occasionally return "USBSUSBSUSB" in
response to SCSI commands when running in UAS mode. Therefore,
disable UAS mode on this dongle.
Signed-off-by: Darrick J. Wong <darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
drivers/usb/storage/unusual_uas.h | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
index 18a283d..3530cb0 100644
--- a/drivers/usb/storage/unusual_uas.h
+++ b/drivers/usb/storage/unusual_uas.h
@@ -40,6 +40,16 @@
* and don't forget to CC: the USB development list <linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
*/
+/*
+ * Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI
+ * commands in UAS mode. Observed with the 1.28 firmware; are there others?
+ */
+UNUSUAL_DEV(0x0984, 0x0301, 0x0128, 0x0128,
+ "Apricorn",
+ "",
+ USB_SC_DEVICE, USB_PR_DEVICE, NULL,
+ US_FL_IGNORE_UAS),
+
/* https://bugzilla.kernel.org/show_bug.cgi?id=79511 */
UNUSUAL_DEV(0x0bc2, 0x2312, 0x0000, 0x9999,
"Seagate",
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] uas: disable UAS on Apricorn SATA dongles
[not found] ` <20141211190111.GD21955-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>
@ 2014-12-12 10:42 ` Hans de Goede
2014-12-12 14:22 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2014-12-12 10:42 UTC (permalink / raw)
To: Darrick J. Wong, Greg Kroah-Hartman
Cc: Gerd Hoffmann, linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-scsi-u79uwXL29TY76Z2rM5mHXA,
usb-storage-ijkIwGHArpdIPJnuZ7Njw4oP9KaGy4wf, stable
<Adding Greg and stable to the cc>
On 11-12-14 20:01, Darrick J. Wong wrote:
> The Apricorn SATA dongle will occasionally return "USBSUSBSUSB" in
> response to SCSI commands when running in UAS mode. Therefore,
> disable UAS mode on this dongle.
>
> Signed-off-by: Darrick J. Wong <darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Looks good:
Acked-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Greg, can you add this to your tree please ?
Regards,
Hans
> ---
> drivers/usb/storage/unusual_uas.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
> index 18a283d..3530cb0 100644
> --- a/drivers/usb/storage/unusual_uas.h
> +++ b/drivers/usb/storage/unusual_uas.h
> @@ -40,6 +40,16 @@
> * and don't forget to CC: the USB development list <linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
> */
>
> +/*
> + * Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI
> + * commands in UAS mode. Observed with the 1.28 firmware; are there others?
> + */
> +UNUSUAL_DEV(0x0984, 0x0301, 0x0128, 0x0128,
> + "Apricorn",
> + "",
> + USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> + US_FL_IGNORE_UAS),
> +
> /* https://bugzilla.kernel.org/show_bug.cgi?id=79511 */
> UNUSUAL_DEV(0x0bc2, 0x2312, 0x0000, 0x9999,
> "Seagate",
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] uas: disable UAS on Apricorn SATA dongles
2014-12-12 10:42 ` Hans de Goede
@ 2014-12-12 14:22 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2014-12-12 14:22 UTC (permalink / raw)
To: Hans de Goede
Cc: Darrick J. Wong, Gerd Hoffmann, linux-usb, linux-scsi,
usb-storage, stable
On Fri, Dec 12, 2014 at 11:42:12AM +0100, Hans de Goede wrote:
> <Adding Greg and stable to the cc>
>
> On 11-12-14 20:01, Darrick J. Wong wrote:
> >The Apricorn SATA dongle will occasionally return "USBSUSBSUSB" in
> >response to SCSI commands when running in UAS mode. Therefore,
> >disable UAS mode on this dongle.
> >
> >Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> Looks good:
>
> Acked-by: Hans de Goede <hdegoede@redhat.com>
>
> Greg, can you add this to your tree please ?
Sure, will queue up after 3.19-rc1 is out.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-12 14:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-11 19:01 [PATCH] uas: disable UAS on Apricorn SATA dongles Darrick J. Wong
[not found] ` <20141211190111.GD21955-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>
2014-12-12 10:42 ` Hans de Goede
2014-12-12 14:22 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).