From: Christoph Hellwig <hch@infradead.org>
To: Sumit.Saxena@avagotech.com
Cc: linux-scsi@vger.kernel.org, stable@vger.kernel.org,
martin.petersen@oracle.com, hch@infradead.org,
jbottomley@parallels.com, kashyap.desai@avagotech.com
Subject: Re: [PATCH 1/8] megaraid_sas : Endianness related bug fixes and code optimization
Date: Thu, 8 Jan 2015 02:38:42 -0800 [thread overview]
Message-ID: <20150108103842.GA600@infradead.org> (raw)
In-Reply-To: <201501051440.t05Ee0Ld029960@palmhbs0.lsi.com>
> -#if defined(__BIG_ENDIAN_BITFIELD)
> - u32 MessageAddress1:24; /* bits 31:8*/
> - u32 RequestFlags:8;
> -#else
> u32 RequestFlags:8;
> - u32 MessageAddress1:24; /* bits 31:8*/
> -#endif
> - u32 MessageAddress2; /* bits 61:32 */
> + u32 MessageAddress1:24;
> + u32 MessageAddress2;
Doesn't this break architectures that set __BIG_ENDIAN_BITFIELD?
next prev parent reply other threads:[~2015-01-08 10:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 14:35 [PATCH 1/8] megaraid_sas : Endianness related bug fixes and code optimization Sumit.Saxena
2015-01-07 0:24 ` Martin K. Petersen
2015-01-08 10:38 ` Christoph Hellwig [this message]
2015-01-08 15:15 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2015-01-08 13:43 Sumit Saxena
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150108103842.GA600@infradead.org \
--to=hch@infradead.org \
--cc=Sumit.Saxena@avagotech.com \
--cc=jbottomley@parallels.com \
--cc=kashyap.desai@avagotech.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).