From: Christoph Hellwig <hch@lst.de>
To: Andy Grover <agrover@redhat.com>
Cc: JBottomley@parallels.com, linux-scsi@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH 2/3] scsi: Move user-shareable stuff in scsi/scsi.h to uapi/scsi/scsi.h
Date: Fri, 9 Jan 2015 11:14:22 +0100 [thread overview]
Message-ID: <20150109101422.GA23804@lst.de> (raw)
In-Reply-To: <1420746479-25949-3-git-send-email-agrover@redhat.com>
On Thu, Jan 08, 2015 at 11:47:58AM -0800, Andy Grover wrote:
> A great many SCSI codes and ioctl values can be made available to userspace
> in a uapi header, while the kernel-only definitions stay in scsi/scsi.h.
>
> scsi/scsi.h also includes uapi/scsi/scsi.h so kernel code need not update
> includes.
SCSI opcodes are not a user API/ABI, so they should not be exported.
I'm fine with having them in their own header that can be copied
into other projects, but guaranteeing any sort of stability for these
defines is a mistake.
next prev parent reply other threads:[~2015-01-09 10:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 19:47 [PATCH 0/3] Add uapi/scsi/scsi.h Andy Grover
2015-01-08 19:47 ` [PATCH 1/3] scsi: add WRITE_VERIFY_16 to scsi.h Andy Grover
2015-01-08 19:47 ` [PATCH 2/3] scsi: Move user-shareable stuff in scsi/scsi.h to uapi/scsi/scsi.h Andy Grover
2015-01-09 10:14 ` Christoph Hellwig [this message]
2015-01-09 15:27 ` James Bottomley
2015-01-09 15:46 ` Christoph Hellwig
2015-01-09 15:50 ` James Bottomley
2015-01-09 16:01 ` Christoph Hellwig
2015-01-09 16:33 ` James Bottomley
2015-01-09 17:11 ` Christoph Hellwig
2015-01-09 17:44 ` James Bottomley
2015-01-08 19:47 ` [PATCH 3/3] scsi: Remove scsi_ioctl.h Andy Grover
2015-01-08 20:35 ` James Bottomley
2015-01-08 21:26 ` Andy Grover
2015-01-09 9:05 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150109101422.GA23804@lst.de \
--to=hch@lst.de \
--cc=JBottomley@parallels.com \
--cc=agrover@redhat.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).