From: Christoph Hellwig <hch@infradead.org>
To: Al Cooper <alcooperx@gmail.com>
Cc: JBottomley@parallels.com, axboe@kernel.dk,
linux-scsi@vger.kernel.org,
TARUISI Hiroaki <taruishi.hiroak@jp.fujitsu.com>
Subject: Re: [PATCH] scsi: Allow retry on UNIT_ATTENTION media changed if not CDROM drive
Date: Mon, 12 Jan 2015 01:44:03 -0800 [thread overview]
Message-ID: <20150112094403.GA2721@infradead.org> (raw)
In-Reply-To: <1420756433-11850-1-git-send-email-alcooperx@gmail.com>
On Thu, Jan 08, 2015 at 05:33:53PM -0500, Al Cooper wrote:
> Previous commit dfcf7775815504d13a1d273073810058caf84b9d added
> a workaround for CD-ROM drives that were out of spec. This is causing
> scsi_check_sense() to return an error instead of NEEDS_RETRY on
> some USB thumb drives that return UNIT_ATTENTION Media Changed
> (ASC/ASCQ 28/00) after resuming from S3. This can cause mounted
> thumb drives to fail on the next access to the filesystem after
> S3 resume. This is masked on many systems because udev/dbus event
> handlers open the /dev/sd* device before filesystem access and the
> open always retries the UNIT_ATTENTION. The fix is to limit the
> original workaround to CDROM drives.
Even better would be quirk for the deice mishandlign the UAs, but I
suspect that's too late now..
prev parent reply other threads:[~2015-01-12 9:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 22:33 [PATCH] scsi: Allow retry on UNIT_ATTENTION media changed if not CDROM drive Al Cooper
2015-01-12 9:44 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150112094403.GA2721@infradead.org \
--to=hch@infradead.org \
--cc=JBottomley@parallels.com \
--cc=alcooperx@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-scsi@vger.kernel.org \
--cc=taruishi.hiroak@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).