From: Tejun Heo <tj@kernel.org>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-ide@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Christoph Hellwig <hch@lst.de>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/2] ata: ahci_platform: fix owner module reference mismatch for scsi host
Date: Tue, 27 Jan 2015 11:21:31 -0500 [thread overview]
Message-ID: <20150127162131.GC12314@htj.dyndns.org> (raw)
In-Reply-To: <1422315299-4614-1-git-send-email-akinobu.mita@gmail.com>
Hello,
On Tue, Jan 27, 2015 at 08:34:58AM +0900, Akinobu Mita wrote:
> The owner module reference of the ahci platform's scsi_host is
> initialized to libahci_platform's one, because these drivers use a
> scsi_host_template defined in libahci_platform. So these drivers can
> be unloaded even if the scsi device is being accessed.
>
> This fixes it by pushing the scsi_host_template from libahci_platform
> to all leaf drivers. The scsi_host_template is passed through a new
> argument of ahci_platform_init_host().
Two things.
* It proly would be a better idea to use the specific platform driver
name for each sht.
* Can you please add comments on top of the SHT macros that these must
be instantiated by the edge drivers and explain why?
Thanks.
--
tejun
prev parent reply other threads:[~2015-01-27 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 23:34 [PATCH 1/2] ata: ahci_platform: fix owner module reference mismatch for scsi host Akinobu Mita
2015-01-26 23:34 ` [PATCH 2/2] ata: pata_platform: " Akinobu Mita
2015-01-27 16:21 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150127162131.GC12314@htj.dyndns.org \
--to=tj@kernel.org \
--cc=JBottomley@parallels.com \
--cc=akinobu.mita@gmail.com \
--cc=hch@lst.de \
--cc=hdegoede@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).