From: Christoph Hellwig <hch@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: michaelc@cs.wisc.edu, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/1] [PATCH REGRESSION] alua: fix bus detach oops
Date: Thu, 29 Jan 2015 00:56:26 -0800 [thread overview]
Message-ID: <20150129085626.GA3715@infradead.org> (raw)
In-Reply-To: <54C9F324.1020102@suse.de>
On Thu, Jan 29, 2015 at 09:45:24AM +0100, Hannes Reinecke wrote:
> Errm.
>
> We save the contents first:
>
> > struct scsi_device_handler *scsi_dh = scsi_dh_data->scsi_dh;
>
> Then set the pointer to NULL:
>
> > sdev->scsi_dh_data = NULL;
>
> and then call 'detach':
>
> > scsi_dh->detach(sdev);
>
> So scsi_dh is _not_ NULL, hence it shouldn't oops.
The actual ->detach method can, and usually does access it.
next prev parent reply other threads:[~2015-01-29 8:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 9:46 [PATCH 1/1] [PATCH REGRESSION] alua: fix bus detach oops michaelc
2015-01-29 8:45 ` Hannes Reinecke
2015-01-29 8:56 ` Christoph Hellwig [this message]
2015-01-29 8:59 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150129085626.GA3715@infradead.org \
--to=hch@infradead.org \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).