* [PATCH] [RESEND] wd719x: add missing .module to wd719x_template
@ 2015-02-09 12:38 Ondrej Zary
2015-02-12 15:09 ` James Bottomley
0 siblings, 1 reply; 3+ messages in thread
From: Ondrej Zary @ 2015-02-09 12:38 UTC (permalink / raw)
To: linux-scsi
wd719x_template is missing the .module field, causing module refcount
not to work, allowing to rmmod the driver while in use (mounted filesystem),
causing an oops.
Set .module to THIS_MODULE to fix the problem.
Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
---
drivers/scsi/wd719x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/wd719x.c b/drivers/scsi/wd719x.c
index 7702664..289ad01 100644
--- a/drivers/scsi/wd719x.c
+++ b/drivers/scsi/wd719x.c
@@ -870,6 +870,7 @@ fail_free_params:
}
static struct scsi_host_template wd719x_template = {
+ .module = THIS_MODULE,
.name = "Western Digital 719x",
.queuecommand = wd719x_queuecommand,
.eh_abort_handler = wd719x_abort,
--
Ondrej Zary
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [RESEND] wd719x: add missing .module to wd719x_template
2015-02-09 12:38 [PATCH] [RESEND] wd719x: add missing .module to wd719x_template Ondrej Zary
@ 2015-02-12 15:09 ` James Bottomley
2015-02-12 15:32 ` Ondrej Zary
0 siblings, 1 reply; 3+ messages in thread
From: James Bottomley @ 2015-02-12 15:09 UTC (permalink / raw)
To: Ondrej Zary; +Cc: linux-scsi
On Mon, 2015-02-09 at 13:38 +0100, Ondrej Zary wrote:
> wd719x_template is missing the .module field, causing module refcount
> not to work, allowing to rmmod the driver while in use (mounted filesystem),
> causing an oops.
>
> Set .module to THIS_MODULE to fix the problem.
This requires a cc to stable, doesn't it?
James
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [RESEND] wd719x: add missing .module to wd719x_template
2015-02-12 15:09 ` James Bottomley
@ 2015-02-12 15:32 ` Ondrej Zary
0 siblings, 0 replies; 3+ messages in thread
From: Ondrej Zary @ 2015-02-12 15:32 UTC (permalink / raw)
To: James Bottomley; +Cc: linux-scsi
On Thursday 12 February 2015, James Bottomley wrote:
> On Mon, 2015-02-09 at 13:38 +0100, Ondrej Zary wrote:
> > wd719x_template is missing the .module field, causing module refcount
> > not to work, allowing to rmmod the driver while in use (mounted
> > filesystem), causing an oops.
> >
> > Set .module to THIS_MODULE to fix the problem.
>
> This requires a cc to stable, doesn't it?
Should go into 3.19-stable.
--
Ondrej Zary
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-12 15:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-09 12:38 [PATCH] [RESEND] wd719x: add missing .module to wd719x_template Ondrej Zary
2015-02-12 15:09 ` James Bottomley
2015-02-12 15:32 ` Ondrej Zary
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).